github/oneuptime
1
1
Fork 0
mirror of https://github.com/OneUptime/oneuptime.git synced 2026-04-06 00:32:12 +02:00
Code Issues 193 Packages Projects Releases Wiki Activity

refactor: remove redundant fetchAggregatedResults calls in dashboard components

Browse Source
This commit is contained in:
Nawaz Dhandala
2026-03-25 22:02:33 +00:00
parent fb3c767056
commit feb86357e8
4 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
App/FeatureSet/Dashboard/src/Components/Dashboard/Components/DashboardChartComponent.tsx
View File

@@ -142,10 +142,6 @@ const DashboardChartComponentElement: FunctionComponent<ComponentProps> = (
props.component.arguments.metricQueryConfigs,
]);
useEffect(() => {
fetchAggregatedResults();
}, []);
if (isLoading) {
return <ComponentLoader />;
}

4
App/FeatureSet/Dashboard/src/Components/Dashboard/Components/DashboardGaugeComponent.tsx
View File

@@ -100,10 +100,6 @@ const DashboardGaugeComponentElement: FunctionComponent<ComponentProps> = (
fetchAggregatedResults();
}, [props.dashboardStartAndEndDate, props.metricTypes, props.refreshTick]);
useEffect(() => {
fetchAggregatedResults();
}, []);
useEffect(() => {
if (
JSONFunctions.isJSONObjectDifferent(

4
App/FeatureSet/Dashboard/src/Components/Dashboard/Components/DashboardTableComponent.tsx
View File

@@ -113,10 +113,6 @@ const DashboardTableComponentElement: FunctionComponent<ComponentProps> = (
}
}, [props.component.arguments.metricQueryConfig]);
useEffect(() => {
fetchAggregatedResults();
}, []);
if (isLoading) {
return <ComponentLoader />;
}

12
App/FeatureSet/Dashboard/src/Components/Dashboard/Components/DashboardValueComponent.tsx
View File

@@ -6,7 +6,7 @@ import { PromiseVoidFunction } from "Common/Types/FunctionTypes";
import MetricViewData from "Common/Types/Metrics/MetricViewData";
import MetricUtil from "../../Metrics/Utils/Metrics";
import API from "Common/UI/Utils/API/API";
import DashboardValueComponent from "Common/Types/Dashboard/DashboardComponents/DashboardValueComponent";
import DashboardValueComponentType from "Common/Types/Dashboard/DashboardComponents/DashboardValueComponent";
import AggregationType from "Common/Types/BaseDatabase/AggregationType";
import MetricQueryConfigData from "Common/Types/Metrics/MetricQueryConfigData";
import JSONFunctions from "Common/Types/JSONFunctions";
@@ -15,10 +15,10 @@ import MetricType from "Common/Models/DatabaseModels/MetricType";
import { RangeStartAndEndDateTimeUtil } from "Common/Types/Time/RangeStartAndEndDateTime";
export interface ComponentProps extends DashboardBaseComponentProps {
component: DashboardValueComponent;
component: DashboardValueComponentType;
}
const DashboardValueComponent: FunctionComponent<ComponentProps> = (
const DashboardValueComponentElement: FunctionComponent<ComponentProps> = (
props: ComponentProps,
): ReactElement => {
const [metricResults, setMetricResults] = React.useState<
@@ -101,10 +101,6 @@ const DashboardValueComponent: FunctionComponent<ComponentProps> = (
fetchAggregatedResults();
}, [props.dashboardStartAndEndDate, props.metricTypes, props.refreshTick]);
useEffect(() => {
fetchAggregatedResults();
}, []);
useEffect(() => {
// set metricQueryConfig to the new value only if it is different from the previous value
if (
@@ -218,4 +214,4 @@ const DashboardValueComponent: FunctionComponent<ComponentProps> = (
);
};
export default DashboardValueComponent;
export default DashboardValueComponentElement;