github/oneuptime
1
1
Fork 0
mirror of https://github.com/OneUptime/oneuptime.git synced 2026-04-06 00:32:12 +02:00
Code Issues 193 Packages Projects Releases Wiki Activity

feat: improve formatting and consistency in MonitorProbeService and MonitorService

Browse Source
This commit is contained in:
Simon Larsen
2025-04-03 19:09:37 +01:00
parent 0d298935df
commit f4b0548133
2 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
Common/Server/Services/MonitorProbeService.ts
View File

@@ -28,7 +28,7 @@ export class Service extends DatabaseService<MonitorProbe> {
probeId: true,
monitor: {
monitoringInterval: true,
}
},
},
limit: LIMIT_PER_PROJECT,
skip: 0,
@@ -56,21 +56,21 @@ export class Service extends DatabaseService<MonitorProbe> {
}
if (nextPing && monitorProbe.id) {
await this.updateOneById({
id: monitorProbe.id,
data: {
nextPingAt: nextPing,
},
props: {
isRoot: true,
},
});
await this.updateOneById({
id: monitorProbe.id,
data: {
nextPingAt: nextPing,
},
props: {
isRoot: true,
},
});
}
}
}
protected override async onBeforeCreate(
createBy: CreateBy<MonitorProbe>
createBy: CreateBy<MonitorProbe>,
): Promise<OnCreate<MonitorProbe>> {
if (
(createBy.data.monitorId || createBy.data.monitor) &&
@@ -107,7 +107,7 @@ export class Service extends DatabaseService<MonitorProbe> {
protected override async onCreateSuccess(
_onCreate: OnCreate<MonitorProbe>,
createdItem: MonitorProbe
createdItem: MonitorProbe,
): Promise<MonitorProbe> {
if (createdItem.probeId) {
await MonitorService.refreshProbeStatus(createdItem.probeId);
@@ -118,7 +118,7 @@ export class Service extends DatabaseService<MonitorProbe> {
protected override async onUpdateSuccess(
onUpdate: OnUpdate<MonitorProbe>,
updatedItemIds: ObjectID[]
updatedItemIds: ObjectID[],
): Promise<OnUpdate<MonitorProbe>> {
// if isEnabled is updated, refresh the probe status
if (onUpdate.updateBy.data.isEnabled !== undefined) {

10
Common/Server/Services/MonitorService.ts
View File

@@ -148,11 +148,11 @@ export class Service extends DatabaseService<Model> {
const createdByUserId: ObjectID | undefined | null =
onUpdate.updateBy.props.userId;
if(onUpdate.updateBy.data.monitoringInterval) {
await MonitorProbeService.updateNextPingAtForMonitor({
monitorId: monitorId
});
}
if (onUpdate.updateBy.data.monitoringInterval) {
await MonitorProbeService.updateNextPingAtForMonitor({
monitorId: monitorId,
});
}
if (onUpdate.updateBy.data.name) {
// add monitor feed.