fix: standardize formatting and improve readability in various files

This commit is contained in:
Simon Larsen
2025-06-13 12:58:46 +01:00
parent 739256bd19
commit c0be3e2fa5
7 changed files with 79 additions and 42 deletions

View File

@@ -115,7 +115,7 @@ const RegisterPage: () => JSX.Element = () => {
required: true,
title: "Full Name",
dataTestId: "name",
disableSpellCheck: true,
disableSpellCheck: true,
},
];

View File

@@ -579,7 +579,7 @@ import OnCallDutyPolicyTimeLogService, {
// statu spage announcement templates
import StatusPageAnnouncementTemplate from "Common/Models/DatabaseModels/StatusPageAnnouncementTemplate";
import StatusPageAnnouncementTemplateService, {
Service as StatusPageAnnouncementTemplateServiceType,
Service as StatusPageAnnouncementTemplateServiceType,
} from "Common/Server/Services/StatusPageAnnouncementTemplateService";
// Open API Spec

View File

@@ -1,32 +1,67 @@
import { MigrationInterface, QueryRunner } from "typeorm";
export class MigrationName1749813704371 implements MigrationInterface {
public name = 'MigrationName1749813704371'
public name = "MigrationName1749813704371";
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`CREATE TABLE "StatusPageAnnouncementTemplate" ("_id" uuid NOT NULL DEFAULT uuid_generate_v4(), "createdAt" TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(), "updatedAt" TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(), "deletedAt" TIMESTAMP WITH TIME ZONE, "version" integer NOT NULL, "projectId" uuid NOT NULL, "templateName" character varying(100) NOT NULL, "templateDescription" character varying(500), "title" character varying(100) NOT NULL, "description" text NOT NULL, "shouldStatusPageSubscribersBeNotified" boolean NOT NULL DEFAULT true, "createdByUserId" uuid, "deletedByUserId" uuid, CONSTRAINT "PK_42d7cd04fe3d2c2e25288483072" PRIMARY KEY ("_id"))`);
await queryRunner.query(`CREATE INDEX "IDX_19d05157cdb68a582d2489bc9e" ON "StatusPageAnnouncementTemplate" ("projectId") `);
await queryRunner.query(`CREATE TABLE "AnnouncementTemplateStatusPage" ("announcementTemplateId" uuid NOT NULL, "statusPageId" uuid NOT NULL, CONSTRAINT "PK_8434706f7e047041ee73a3e8b76" PRIMARY KEY ("announcementTemplateId", "statusPageId"))`);
await queryRunner.query(`CREATE INDEX "IDX_182e3a7c2c910755382971e473" ON "AnnouncementTemplateStatusPage" ("announcementTemplateId") `);
await queryRunner.query(`CREATE INDEX "IDX_d64c5bcc98bd6a09fee1f5b247" ON "AnnouncementTemplateStatusPage" ("statusPageId") `);
await queryRunner.query(`ALTER TABLE "StatusPageAnnouncementTemplate" ADD CONSTRAINT "FK_19d05157cdb68a582d2489bc9e1" FOREIGN KEY ("projectId") REFERENCES "Project"("_id") ON DELETE CASCADE ON UPDATE NO ACTION`);
await queryRunner.query(`ALTER TABLE "StatusPageAnnouncementTemplate" ADD CONSTRAINT "FK_9f1b244a75d53bd2d208934551a" FOREIGN KEY ("createdByUserId") REFERENCES "User"("_id") ON DELETE SET NULL ON UPDATE NO ACTION`);
await queryRunner.query(`ALTER TABLE "StatusPageAnnouncementTemplate" ADD CONSTRAINT "FK_ced5ce354456a65d71e39cd8e7d" FOREIGN KEY ("deletedByUserId") REFERENCES "User"("_id") ON DELETE SET NULL ON UPDATE NO ACTION`);
await queryRunner.query(`ALTER TABLE "AnnouncementTemplateStatusPage" ADD CONSTRAINT "FK_182e3a7c2c910755382971e4739" FOREIGN KEY ("announcementTemplateId") REFERENCES "StatusPageAnnouncementTemplate"("_id") ON DELETE CASCADE ON UPDATE CASCADE`);
await queryRunner.query(`ALTER TABLE "AnnouncementTemplateStatusPage" ADD CONSTRAINT "FK_d64c5bcc98bd6a09fee1f5b2473" FOREIGN KEY ("statusPageId") REFERENCES "StatusPage"("_id") ON DELETE CASCADE ON UPDATE CASCADE`);
}
public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "AnnouncementTemplateStatusPage" DROP CONSTRAINT "FK_d64c5bcc98bd6a09fee1f5b2473"`);
await queryRunner.query(`ALTER TABLE "AnnouncementTemplateStatusPage" DROP CONSTRAINT "FK_182e3a7c2c910755382971e4739"`);
await queryRunner.query(`ALTER TABLE "StatusPageAnnouncementTemplate" DROP CONSTRAINT "FK_ced5ce354456a65d71e39cd8e7d"`);
await queryRunner.query(`ALTER TABLE "StatusPageAnnouncementTemplate" DROP CONSTRAINT "FK_9f1b244a75d53bd2d208934551a"`);
await queryRunner.query(`ALTER TABLE "StatusPageAnnouncementTemplate" DROP CONSTRAINT "FK_19d05157cdb68a582d2489bc9e1"`);
await queryRunner.query(`DROP INDEX "public"."IDX_d64c5bcc98bd6a09fee1f5b247"`);
await queryRunner.query(`DROP INDEX "public"."IDX_182e3a7c2c910755382971e473"`);
await queryRunner.query(`DROP TABLE "AnnouncementTemplateStatusPage"`);
await queryRunner.query(`DROP INDEX "public"."IDX_19d05157cdb68a582d2489bc9e"`);
await queryRunner.query(`DROP TABLE "StatusPageAnnouncementTemplate"`);
}
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(
`CREATE TABLE "StatusPageAnnouncementTemplate" ("_id" uuid NOT NULL DEFAULT uuid_generate_v4(), "createdAt" TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(), "updatedAt" TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(), "deletedAt" TIMESTAMP WITH TIME ZONE, "version" integer NOT NULL, "projectId" uuid NOT NULL, "templateName" character varying(100) NOT NULL, "templateDescription" character varying(500), "title" character varying(100) NOT NULL, "description" text NOT NULL, "shouldStatusPageSubscribersBeNotified" boolean NOT NULL DEFAULT true, "createdByUserId" uuid, "deletedByUserId" uuid, CONSTRAINT "PK_42d7cd04fe3d2c2e25288483072" PRIMARY KEY ("_id"))`,
);
await queryRunner.query(
`CREATE INDEX "IDX_19d05157cdb68a582d2489bc9e" ON "StatusPageAnnouncementTemplate" ("projectId") `,
);
await queryRunner.query(
`CREATE TABLE "AnnouncementTemplateStatusPage" ("announcementTemplateId" uuid NOT NULL, "statusPageId" uuid NOT NULL, CONSTRAINT "PK_8434706f7e047041ee73a3e8b76" PRIMARY KEY ("announcementTemplateId", "statusPageId"))`,
);
await queryRunner.query(
`CREATE INDEX "IDX_182e3a7c2c910755382971e473" ON "AnnouncementTemplateStatusPage" ("announcementTemplateId") `,
);
await queryRunner.query(
`CREATE INDEX "IDX_d64c5bcc98bd6a09fee1f5b247" ON "AnnouncementTemplateStatusPage" ("statusPageId") `,
);
await queryRunner.query(
`ALTER TABLE "StatusPageAnnouncementTemplate" ADD CONSTRAINT "FK_19d05157cdb68a582d2489bc9e1" FOREIGN KEY ("projectId") REFERENCES "Project"("_id") ON DELETE CASCADE ON UPDATE NO ACTION`,
);
await queryRunner.query(
`ALTER TABLE "StatusPageAnnouncementTemplate" ADD CONSTRAINT "FK_9f1b244a75d53bd2d208934551a" FOREIGN KEY ("createdByUserId") REFERENCES "User"("_id") ON DELETE SET NULL ON UPDATE NO ACTION`,
);
await queryRunner.query(
`ALTER TABLE "StatusPageAnnouncementTemplate" ADD CONSTRAINT "FK_ced5ce354456a65d71e39cd8e7d" FOREIGN KEY ("deletedByUserId") REFERENCES "User"("_id") ON DELETE SET NULL ON UPDATE NO ACTION`,
);
await queryRunner.query(
`ALTER TABLE "AnnouncementTemplateStatusPage" ADD CONSTRAINT "FK_182e3a7c2c910755382971e4739" FOREIGN KEY ("announcementTemplateId") REFERENCES "StatusPageAnnouncementTemplate"("_id") ON DELETE CASCADE ON UPDATE CASCADE`,
);
await queryRunner.query(
`ALTER TABLE "AnnouncementTemplateStatusPage" ADD CONSTRAINT "FK_d64c5bcc98bd6a09fee1f5b2473" FOREIGN KEY ("statusPageId") REFERENCES "StatusPage"("_id") ON DELETE CASCADE ON UPDATE CASCADE`,
);
}
public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(
`ALTER TABLE "AnnouncementTemplateStatusPage" DROP CONSTRAINT "FK_d64c5bcc98bd6a09fee1f5b2473"`,
);
await queryRunner.query(
`ALTER TABLE "AnnouncementTemplateStatusPage" DROP CONSTRAINT "FK_182e3a7c2c910755382971e4739"`,
);
await queryRunner.query(
`ALTER TABLE "StatusPageAnnouncementTemplate" DROP CONSTRAINT "FK_ced5ce354456a65d71e39cd8e7d"`,
);
await queryRunner.query(
`ALTER TABLE "StatusPageAnnouncementTemplate" DROP CONSTRAINT "FK_9f1b244a75d53bd2d208934551a"`,
);
await queryRunner.query(
`ALTER TABLE "StatusPageAnnouncementTemplate" DROP CONSTRAINT "FK_19d05157cdb68a582d2489bc9e1"`,
);
await queryRunner.query(
`DROP INDEX "public"."IDX_d64c5bcc98bd6a09fee1f5b247"`,
);
await queryRunner.query(
`DROP INDEX "public"."IDX_182e3a7c2c910755382971e473"`,
);
await queryRunner.query(`DROP TABLE "AnnouncementTemplateStatusPage"`);
await queryRunner.query(
`DROP INDEX "public"."IDX_19d05157cdb68a582d2489bc9e"`,
);
await queryRunner.query(`DROP TABLE "StatusPageAnnouncementTemplate"`);
}
}

View File

@@ -277,5 +277,5 @@ export default [
MigrationName1748456937826,
MigrationName1749065784320,
MigrationName1749133333893,
MigrationName1749813704371
MigrationName1749813704371,
];

View File

@@ -9,9 +9,9 @@ describe("MarkdownEditor with SpellCheck", () => {
<MarkdownEditor
initialValue="This is a test with speling errors"
placeholder="Enter markdown here..."
/>
/>,
);
const textarea = screen.getByRole("textbox");
expect(textarea.spellcheck).toBe(true);
});
@@ -22,9 +22,9 @@ describe("MarkdownEditor with SpellCheck", () => {
initialValue="This is a test with speling errors"
placeholder="Enter markdown here..."
disableSpellCheck={true}
/>
/>,
);
const textarea = screen.getByRole("textbox");
expect(textarea.spellcheck).toBe(false);
});
@@ -35,9 +35,9 @@ describe("MarkdownEditor with SpellCheck", () => {
initialValue="This is a test with speling errors"
placeholder="Enter markdown here..."
disableSpellCheck={false}
/>
/>,
);
let textarea = screen.getByRole("textbox");
expect(textarea.spellcheck).toBe(true);
@@ -46,9 +46,9 @@ describe("MarkdownEditor with SpellCheck", () => {
initialValue="This is a test with speling errors"
placeholder="Enter markdown here..."
disableSpellCheck={true}
/>
/>,
);
textarea = screen.getByRole("textbox");
expect(textarea.spellcheck).toBe(false);
});

View File

@@ -96,7 +96,7 @@ const CodeEditor: FunctionComponent<ComponentProps> = (
const editor = editorRef.current;
const domNode = editor.getDomNode();
if (domNode) {
const textareaElement = domNode.querySelector('textarea');
const textareaElement = domNode.querySelector("textarea");
if (textareaElement) {
textareaElement.spellcheck = !props.disableSpellCheck;
}
@@ -152,12 +152,12 @@ const CodeEditor: FunctionComponent<ComponentProps> = (
}}
onMount={(editor, monaco) => {
editorRef.current = editor;
// Configure spell check for Markdown
if (props.type === CodeType.Markdown) {
const domNode = editor.getDomNode();
if (domNode) {
const textareaElement = domNode.querySelector('textarea');
const textareaElement = domNode.querySelector("textarea");
if (textareaElement) {
textareaElement.spellcheck = !props.disableSpellCheck;
}

View File

@@ -1577,10 +1577,12 @@ const RouteMap: Dictionary<Route> = {
SettingsRoutePath[PageMap.SETTINGS_STATUS_PAGE_ANNOUNCEMENT_TEMPLATES]
}`,
),
[PageMap.SETTINGS_STATUS_PAGE_ANNOUNCEMENT_TEMPLATES_VIEW]: new Route(
`/dashboard/${RouteParams.ProjectID}/settings/${
SettingsRoutePath[PageMap.SETTINGS_STATUS_PAGE_ANNOUNCEMENT_TEMPLATES_VIEW]
SettingsRoutePath[
PageMap.SETTINGS_STATUS_PAGE_ANNOUNCEMENT_TEMPLATES_VIEW
]
}`,
),