github/oneuptime
1
1
Fork 0
mirror of https://github.com/OneUptime/oneuptime.git synced 2026-04-06 00:32:12 +02:00
Code Issues 193 Packages Projects Releases Wiki Activity

refactor: simplify logging for previous status duration and improve code formatting

Browse Source
This commit is contained in:
Nawaz Dhandala
2025-12-04 09:17:31 +00:00
parent d20a125742
commit 91bf55dc20
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
Worker/Jobs/MonitorOwners/SendStatusChangeNotification.ts
View File

@@ -126,7 +126,6 @@ RunCron(
monitorStatusTimeline.startsAt || monitorStatusTimeline.createdAt;
if (previousStartTime && currentStartTime) {
logger.debug(
`Calculating duration between ${previousStartTime.toISOString()} and ${currentStartTime.toISOString()}`,
);
@@ -141,10 +140,7 @@ RunCron(
durationInSeconds,
);
logger.debug(
`Previous status duration: ${previousStatusDuration}`,
);
logger.debug(`Previous status duration: ${previousStatusDuration}`);
}
}
}
@@ -174,9 +170,10 @@ RunCron(
for (const user of owners) {
// Build the "Was X for Y" string
const previousStatusDurationText: string = previousStatus?.name && previousStatusDuration
? `Was ${previousStatus.name} for ${previousStatusDuration}`
: "";
const previousStatusDurationText: string =
previousStatus?.name && previousStatusDuration
? `Was ${previousStatus.name} for ${previousStatusDuration}`
: "";
const vars: Dictionary<string> = {
monitorName: monitor.name!,
@@ -216,22 +213,25 @@ RunCron(
const emailMessage: EmailEnvelope = {
templateType: EmailTemplateType.MonitorOwnerStatusChanged,
vars: vars,
subject: `[Monitor] ${monitor.name || "Monitor"
} is ${monitorStatus!.name!}`,
subject: `[Monitor] ${
monitor.name || "Monitor"
} is ${monitorStatus!.name!}`,
};
const sms: SMSMessage = {
message: `This is a message from OneUptime. ${monitor.name || "Monitor"
} status changed${previousStatus ? ` from ${previousStatus.name}` : ""} to ${monitorStatus!
.name!}. To unsubscribe from this notification go to User Settings in OneUptime Dashboard.`,
message: `This is a message from OneUptime. ${
monitor.name || "Monitor"
} status changed${previousStatus ? ` from ${previousStatus.name}` : ""} to ${monitorStatus!
.name!}. To unsubscribe from this notification go to User Settings in OneUptime Dashboard.`,
};
const callMessage: CallRequestMessage = {
data: [
{
sayMessage: `This is a message from OneUptime. ${monitor.name || "Monitor"
} status changed${previousStatus ? ` from ${previousStatus.name}` : ""} to ${monitorStatus!
.name!}. To unsubscribe from this notification go to User Settings in OneUptime Dashboard. Good bye.`,
sayMessage: `This is a message from OneUptime. ${
monitor.name || "Monitor"
} status changed${previousStatus ? ` from ${previousStatus.name}` : ""} to ${monitorStatus!
.name!}. To unsubscribe from this notification go to User Settings in OneUptime Dashboard. Good bye.`,
},
],
};