github/oneuptime
1
1
Fork 0
mirror of https://github.com/OneUptime/oneuptime.git synced 2026-04-06 00:32:12 +02:00
Code Issues 193 Packages Projects Releases Wiki Activity

style: Improve code formatting and readability in various files

Browse Source
This commit is contained in:
Nawaz Dhandala
2025-12-28 12:40:00 +00:00
parent 45a1748d50
commit 755b76cbce
6 changed files with 83 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Common/Models/DatabaseModels/AIAgentTaskLog.ts
View File

@@ -296,7 +296,8 @@ export default class AIAgentTaskLog extends BaseModel {
required: true,
type: TableColumnType.ShortText,
title: "Severity",
description: "Severity level of this log entry (e.g., Information, Warning, Error).",
description:
"Severity level of this log entry (e.g., Information, Warning, Error).",
})
@Column({
nullable: false,

3
Common/Server/API/AIAgentTaskLogAPI.ts
View File

@@ -76,7 +76,8 @@ export default class AIAgentTaskLogAPI extends BaseAPI<
const message: string = data["message"] as string;
/* Validate severity value */
const validSeverities: Array<LogSeverity> = Object.values(LogSeverity);
const validSeverities: Array<LogSeverity> =
Object.values(LogSeverity);
if (!validSeverities.includes(severity)) {
return Response.sendErrorResponse(
req,

47
Common/Server/Infrastructure/Postgres/SchemaMigrations/1766923324521-MigrationName.ts
View File

@@ -1,22 +1,37 @@
import { MigrationInterface, QueryRunner } from "typeorm";
export class MigrationName1766923324521 implements MigrationInterface {
public name = 'MigrationName1766923324521'
public name = "MigrationName1766923324521";
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" DROP COLUMN "logs"`);
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" ADD "severity" character varying(50) NOT NULL`);
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" ADD "message" text NOT NULL`);
await queryRunner.query(`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "rotation" SET DEFAULT '{"_type":"Recurring","value":{"intervalType":"Day","intervalCount":{"_type":"PositiveNumber","value":1}}}'`);
await queryRunner.query(`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "restrictionTimes" SET DEFAULT '{"_type":"RestrictionTimes","value":{"restictionType":"None","dayRestrictionTimes":null,"weeklyRestrictionTimes":[]}}'`);
}
public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "restrictionTimes" SET DEFAULT '{"_type": "RestrictionTimes", "value": {"restictionType": "None", "dayRestrictionTimes": null, "weeklyRestrictionTimes": []}}'`);
await queryRunner.query(`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "rotation" SET DEFAULT '{"_type": "Recurring", "value": {"intervalType": "Day", "intervalCount": {"_type": "PositiveNumber", "value": 1}}}'`);
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" DROP COLUMN "message"`);
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" DROP COLUMN "severity"`);
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" ADD "logs" jsonb`);
}
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" DROP COLUMN "logs"`);
await queryRunner.query(
`ALTER TABLE "AIAgentTaskLog" ADD "severity" character varying(50) NOT NULL`,
);
await queryRunner.query(
`ALTER TABLE "AIAgentTaskLog" ADD "message" text NOT NULL`,
);
await queryRunner.query(
`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "rotation" SET DEFAULT '{"_type":"Recurring","value":{"intervalType":"Day","intervalCount":{"_type":"PositiveNumber","value":1}}}'`,
);
await queryRunner.query(
`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "restrictionTimes" SET DEFAULT '{"_type":"RestrictionTimes","value":{"restictionType":"None","dayRestrictionTimes":null,"weeklyRestrictionTimes":[]}}'`,
);
}
public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(
`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "restrictionTimes" SET DEFAULT '{"_type": "RestrictionTimes", "value": {"restictionType": "None", "dayRestrictionTimes": null, "weeklyRestrictionTimes": []}}'`,
);
await queryRunner.query(
`ALTER TABLE "OnCallDutyPolicyScheduleLayer" ALTER COLUMN "rotation" SET DEFAULT '{"_type": "Recurring", "value": {"intervalType": "Day", "intervalCount": {"_type": "PositiveNumber", "value": 1}}}'`,
);
await queryRunner.query(
`ALTER TABLE "AIAgentTaskLog" DROP COLUMN "message"`,
);
await queryRunner.query(
`ALTER TABLE "AIAgentTaskLog" DROP COLUMN "severity"`,
);
await queryRunner.query(`ALTER TABLE "AIAgentTaskLog" ADD "logs" jsonb`);
}
}

2
Common/Server/Infrastructure/Postgres/SchemaMigrations/Index.ts
View File

@@ -425,5 +425,5 @@ export default [
MigrationName1766774689743,
MigrationName1766777986427,
AddAIAgentIsDefault1766918848434,
MigrationName1766923324521
MigrationName1766923324521,
];

24
Telemetry/Tests/Utils/Exception.test.ts
View File

@@ -47,10 +47,8 @@ describe("ExceptionUtil", () => {
});
test("normalizes MongoDB ObjectIDs", () => {
const message1: string =
"Document not found: 507f1f77bcf86cd799439011";
const message2: string =
"Document not found: 60a1b2c3d4e5f6a7b8c9d0e1";
const message1: string = "Document not found: 507f1f77bcf86cd799439011";
const message2: string = "Document not found: 60a1b2c3d4e5f6a7b8c9d0e1";
const normalized1: string =
ExceptionUtil.normalizeForFingerprint(message1);
@@ -88,10 +86,8 @@ describe("ExceptionUtil", () => {
});
test("normalizes timestamps", () => {
const message1: string =
"Request failed at 2024-03-15T14:30:00.000Z";
const message2: string =
"Request failed at 2024-12-01T09:15:30.500Z";
const message1: string = "Request failed at 2024-03-15T14:30:00.000Z";
const message2: string = "Request failed at 2024-12-01T09:15:30.500Z";
const normalized1: string =
ExceptionUtil.normalizeForFingerprint(message1);
@@ -155,8 +151,10 @@ describe("ExceptionUtil", () => {
});
test("normalizes large numbers", () => {
// Large numbers (8+ digits) may match hex pattern since 0-9 are valid hex
// The important thing is both normalize to the same value
/*
* Large numbers (8+ digits) may match hex pattern since 0-9 are valid hex
* The important thing is both normalize to the same value
*/
const message1: string = "User 8234567890 not found";
const message2: string = "User 9876543210 not found";
@@ -190,9 +188,11 @@ describe("ExceptionUtil", () => {
test("handles null/undefined gracefully", () => {
// @ts-expect-error - testing edge case
const normalizedNull: string = ExceptionUtil.normalizeForFingerprint(null);
const normalizedNull: string =
ExceptionUtil.normalizeForFingerprint(null);
// @ts-expect-error - testing edge case
const normalizedUndefined: string = ExceptionUtil.normalizeForFingerprint(undefined);
const normalizedUndefined: string =
ExceptionUtil.normalizeForFingerprint(undefined);
expect(normalizedNull).toBe("");
expect(normalizedUndefined).toBe("");

74
Telemetry/Utils/Exception.ts
View File

@@ -49,16 +49,20 @@ export default class ExceptionUtil {
// 2. MongoDB ObjectIDs (24 hex characters)
normalized = normalized.replace(/\b[0-9a-f]{24}\b/gi, "<OBJECT_ID>");
// 3. Stripe-style IDs (e.g., sub_xxx, cus_xxx, pi_xxx, ch_xxx, etc.)
// These have a prefix followed by underscore and alphanumeric characters
/*
* 3. Stripe-style IDs (e.g., sub_xxx, cus_xxx, pi_xxx, ch_xxx, etc.)
* These have a prefix followed by underscore and alphanumeric characters
*/
normalized = normalized.replace(
/\b(sub|cus|pi|ch|pm|card|price|prod|inv|txn|evt|req|acct|payout|ba|btok|src|tok|seti|si|cs|link|file|dp|icr|ii|il|is|isci|mbur|or|po|qt|rcpt|re|refund|sku|tax|txi|tr|us|wh)_[A-Za-z0-9]{10,32}\b/g,
"<STRIPE_ID>",
);
// 4. Generic API/Service IDs - alphanumeric strings that look like IDs
// Matches patterns like: prefix_alphanumeric or just long alphanumeric strings
// Common in many services (AWS, GCP, etc.)
/*
* 4. Generic API/Service IDs - alphanumeric strings that look like IDs
* Matches patterns like: prefix_alphanumeric or just long alphanumeric strings
* Common in many services (AWS, GCP, etc.)
*/
normalized = normalized.replace(
/\b[a-z]{2,10}_[A-Za-z0-9]{8,}\b/g,
"<SERVICE_ID>",
@@ -95,15 +99,19 @@ export default class ExceptionUtil {
"<EMAIL>",
);
// 10. URLs with dynamic paths/query params (normalize the dynamic parts)
// Keep the domain but normalize path segments that look like IDs
/*
* 10. URLs with dynamic paths/query params (normalize the dynamic parts)
* Keep the domain but normalize path segments that look like IDs
*/
normalized = normalized.replace(
/\/[0-9a-f]{8,}(?=\/|$|\?|#|\s|'|")/gi,
"/<ID>",
);
// 11. Timestamps in various formats
// ISO 8601 timestamps
/*
* 11. Timestamps in various formats
* ISO 8601 timestamps
*/
normalized = normalized.replace(
/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(?:\.\d+)?(?:Z|[+-]\d{2}:?\d{2})?/g,
"<TIMESTAMP>",
@@ -112,20 +120,11 @@ export default class ExceptionUtil {
normalized = normalized.replace(/\b1[0-9]{9,12}\b/g, "<TIMESTAMP>");
// 12. Date formats (YYYY-MM-DD, MM/DD/YYYY, etc.)
normalized = normalized.replace(
/\b\d{4}[-/]\d{2}[-/]\d{2}\b/g,
"<DATE>",
);
normalized = normalized.replace(
/\b\d{2}[-/]\d{2}[-/]\d{4}\b/g,
"<DATE>",
);
normalized = normalized.replace(/\b\d{4}[-/]\d{2}[-/]\d{2}\b/g, "<DATE>");
normalized = normalized.replace(/\b\d{2}[-/]\d{2}[-/]\d{4}\b/g, "<DATE>");
// 13. Time formats (HH:MM:SS, HH:MM)
normalized = normalized.replace(
/\b\d{2}:\d{2}(?::\d{2})?\b/g,
"<TIME>",
);
normalized = normalized.replace(/\b\d{2}:\d{2}(?::\d{2})?\b/g, "<TIME>");
// 14. Memory addresses (0x followed by hex)
normalized = normalized.replace(/\b0x[0-9a-fA-F]+\b/g, "<MEMORY_ADDR>");
@@ -157,22 +156,20 @@ export default class ExceptionUtil {
// 19. Hex strings that are likely IDs (8+ chars)
normalized = normalized.replace(/\b[0-9a-f]{8,}\b/gi, "<HEX_ID>");
// 20. Quoted strings containing IDs or dynamic values
// Match strings in single or double quotes that look like IDs
normalized = normalized.replace(
/'[A-Za-z0-9_-]{16,}'/g,
"'<ID>'",
);
normalized = normalized.replace(
/"[A-Za-z0-9_-]{16,}"/g,
'"<ID>"',
);
/*
* 20. Quoted strings containing IDs or dynamic values
* Match strings in single or double quotes that look like IDs
*/
normalized = normalized.replace(/'[A-Za-z0-9_-]{16,}'/g, "'<ID>'");
normalized = normalized.replace(/"[A-Za-z0-9_-]{16,}"/g, '"<ID>"');
// 21. Port numbers in URLs or connection strings
normalized = normalized.replace(/:(\d{4,5})(?=\/|$|\s)/g, ":<PORT>");
// 22. Line numbers in stack traces (keep for context, but normalize large numbers)
// This normalizes specific line/column references that might vary
/*
* 22. Line numbers in stack traces (keep for context, but normalize large numbers)
* This normalizes specific line/column references that might vary
*/
normalized = normalized.replace(/:\d+:\d+\)?$/gm, ":<LINE>:<COL>)");
// 23. Process/Thread IDs
@@ -180,10 +177,7 @@ export default class ExceptionUtil {
normalized = normalized.replace(/\bTID[:\s]*\d+\b/gi, "TID:<TID>");
// 24. Numeric IDs in common patterns (id=123, id: 123, etc.)
normalized = normalized.replace(
/\bid[=:\s]*['"]?\d+['"]?/gi,
"id=<ID>",
);
normalized = normalized.replace(/\bid[=:\s]*['"]?\d+['"]?/gi, "id=<ID>");
// 25. Large numbers that are likely IDs (more than 6 digits)
normalized = normalized.replace(/\b\d{7,}\b/g, "<NUMBER>");
@@ -198,8 +192,10 @@ export default class ExceptionUtil {
const projectId: string = data.projectId?.toString() || "";
const serviceId: string = data.serviceId?.toString() || "";
// Normalize message and stack trace to group similar exceptions together
// This replaces dynamic values like IDs, timestamps, etc. with placeholders
/*
* Normalize message and stack trace to group similar exceptions together
* This replaces dynamic values like IDs, timestamps, etc. with placeholders
*/
const normalizedMessage: string =
ExceptionUtil.normalizeForFingerprint(message);
const normalizedStackTrace: string =