refactor(proxy-config): robust hostname/port extraction, normalize ports, and tidy formatting

- Improve extractHostnameAndPort and splitHostAndPort to handle IPv6 brackets, single-colon ports, and trimmed port values; return explicit result objects.
- Normalize host/port parsing logic and ensure port values are trimmed before use.
- Consolidate import formatting and split long method signatures for readability.
- Minor formatting/whitespace cleanups in Probe Config, Alive, Register, Monitor, and NO_PROXY parsing.

Probe/Config.ts

@@ -114,7 +114,9 @@ const rawNoProxy: string | undefined =
 export const NO_PROXY: Array<string> = rawNoProxy
   ? rawNoProxy
       .split(",")
-      .map((value: string) => value.trim())
+      .map((value: string) => {
+        return value.trim();
+      })
       .reduce<Array<string>>((accumulator: Array<string>, current: string) => {
         if (!current) {
           return accumulator;
@@ -122,8 +124,12 @@ export const NO_PROXY: Array<string> = rawNoProxy
 
         const parts: Array<string> = current
           .split(/\s+/)
-          .map((item: string) => item.trim())
-          .filter((item: string) => item.length > 0);
+          .map((item: string) => {
+            return item.trim();
+          })
+          .filter((item: string) => {
+            return item.length > 0;
+          });
 
         return accumulator.concat(parts);
       }, [])

Probe/Jobs/Alive.ts

@@ -36,9 +36,9 @@ const InitJob: VoidFunction = (): void => {
 
       logger.debug("Probe ID: " + probeId.toString());
 
-      const aliveUrl: URL = URL.fromString(PROBE_INGEST_URL.toString()).addRoute(
-        "/alive",
-      );
+      const aliveUrl: URL = URL.fromString(
+        PROBE_INGEST_URL.toString(),
+      ).addRoute("/alive");
 
       const result: HTTPResponse<JSONObject> = await API.post({
         url: aliveUrl,

Probe/Services/Register.ts

@@ -153,9 +153,9 @@ export default class Register {
         return process.exit();
       }
 
-      const aliveUrl: URL = URL.fromString(PROBE_INGEST_URL.toString()).addRoute(
-        "/alive",
-      );
+      const aliveUrl: URL = URL.fromString(
+        PROBE_INGEST_URL.toString(),
+      ).addRoute("/alive");
 
       await API.post({
         url: aliveUrl,

Probe/Utils/Monitors/Monitor.ts

@@ -66,8 +66,7 @@ export default class MonitorUtil {
         const monitorTestIngestUrl: URL = URL.fromString(
           PROBE_INGEST_URL.toString(),
         ).addRoute(
-          "/probe/response/monitor-test-ingest/" +
-            monitorTest.id?.toString(),
+          "/probe/response/monitor-test-ingest/" + monitorTest.id?.toString(),
         );
 
         await API.fetch<JSONObject>({

Probe/Utils/ProxyConfig.ts

@@ -1,8 +1,4 @@
-import {
-  HTTP_PROXY_URL,
-  HTTPS_PROXY_URL,
-  NO_PROXY,
-} from "../Config";
+import { HTTP_PROXY_URL, HTTPS_PROXY_URL, NO_PROXY } from "../Config";
 import { HttpsProxyAgent } from "https-proxy-agent";
 import { HttpProxyAgent } from "http-proxy-agent";
 import logger from "Common/Server/Utils/Logger";
@@ -75,7 +71,9 @@ export default class ProxyConfig {
     return HTTPS_PROXY_URL;
   }
 
-  public static getHttpProxyAgent(targetUrl?: TargetUrl): HttpProxyAgent<string> | null {
+  public static getHttpProxyAgent(
+    targetUrl?: TargetUrl,
+  ): HttpProxyAgent<string> | null {
     if (this.shouldBypassProxy(targetUrl)) {
       return null;
     }
@@ -83,7 +81,9 @@ export default class ProxyConfig {
     return this.httpProxyAgent;
   }
 
-  public static getHttpsProxyAgent(targetUrl?: TargetUrl): HttpsProxyAgent<string> | null {
+  public static getHttpsProxyAgent(
+    targetUrl?: TargetUrl,
+  ): HttpsProxyAgent<string> | null {
     if (this.shouldBypassProxy(targetUrl)) {
       return null;
     }
@@ -91,7 +91,9 @@ export default class ProxyConfig {
     return this.httpsProxyAgent;
   }
 
-  public static getRequestProxyAgents(targetUrl: TargetUrl): Readonly<ProxyAgents> {
+  public static getRequestProxyAgents(
+    targetUrl: TargetUrl,
+  ): Readonly<ProxyAgents> {
     if (this.shouldBypassProxy(targetUrl)) {
       return {};
     }
@@ -161,31 +163,56 @@ export default class ProxyConfig {
         : `http://${value}`;
       const parsedUrl: NodeURL = new NodeURL(valueForParsing);
 
-      return {
-        hostname: parsedUrl.hostname || null,
-        port: parsedUrl.port || undefined,
+      const hostnameResult: string | null = parsedUrl.hostname || null;
+      const portValue: string | undefined = parsedUrl.port
+        ? parsedUrl.port.trim()
+        : undefined;
+
+      const result: { hostname: string | null; port?: string } = {
+        hostname: hostnameResult,
       };
+
+      if (portValue) {
+        result.port = portValue;
+      }
+
+      return result;
     } catch {
       if (value.startsWith("[") && value.includes("]")) {
         const closingIndex: number = value.indexOf("]");
         const hostPart: string = value.substring(1, closingIndex);
         const remainder: string = value.substring(closingIndex + 1).trim();
-        const port: string | undefined = remainder.startsWith(":")
+        const portCandidate: string | undefined = remainder.startsWith(":")
           ? remainder.substring(1).trim() || undefined
           : undefined;
 
-        return {
+        const result: { hostname: string | null; port?: string } = {
           hostname: hostPart,
-          port,
         };
+
+        if (portCandidate) {
+          result.port = portCandidate;
+        }
+
+        return result;
       }
 
-      const parts: Array<string> = value.split(":");
-      if (parts.length === 2) {
-        return {
-          hostname: parts[0],
-          port: parts[1],
+      const firstColonIndex: number = value.indexOf(":");
+      const lastColonIndex: number = value.lastIndexOf(":");
+
+      if (firstColonIndex > -1 && firstColonIndex === lastColonIndex) {
+        const hostPart: string = value.substring(0, firstColonIndex).trim();
+        const portPart: string = value.substring(firstColonIndex + 1).trim();
+
+        const result: { hostname: string | null; port?: string } = {
+          hostname: hostPart,
         };
+
+        if (portPart) {
+          result.port = portPart;
+        }
+
+        return result;
       }
 
       return {
@@ -214,22 +241,41 @@ export default class ProxyConfig {
       const closingIndex: number = trimmedValue.indexOf("]");
       const hostPart: string = trimmedValue.substring(0, closingIndex + 1);
       const remainder: string = trimmedValue.substring(closingIndex + 1).trim();
-      const port: string | undefined = remainder.startsWith(":")
+      const portCandidate: string | undefined = remainder.startsWith(":")
         ? remainder.substring(1).trim() || undefined
         : undefined;
 
-      return {
+      const result: { host: string; port?: string } = {
         host: hostPart,
-        port,
       };
+
+      if (portCandidate) {
+        result.port = portCandidate;
+      }
+
+      return result;
     }
 
-    const segments: Array<string> = trimmedValue.split(":");
-    if (segments.length === 2) {
-      return {
-        host: segments[0],
-        port: segments[1].trim() || undefined,
+    const firstColonIndex: number = trimmedValue.indexOf(":");
+    const lastColonIndex: number = trimmedValue.lastIndexOf(":");
+
+    if (firstColonIndex > -1 && firstColonIndex === lastColonIndex) {
+      const hostPart: string = trimmedValue
+        .substring(0, firstColonIndex)
+        .trim();
+      const portPart: string = trimmedValue
+        .substring(firstColonIndex + 1)
+        .trim();
+
+      const result: { host: string; port?: string } = {
+        host: hostPart,
       };
+
+      if (portPart) {
+        result.port = portPart;
+      }
+
+      return result;
     }
 
     return {