github/VRCX
1
1
Fork 0
mirror of https://github.com/vrcx-team/VRCX.git synced 2026-04-06 00:32:02 +02:00
Code Issues 51 Packages Projects Releases Wiki Activity

fix: Stop HasProcessExited from leaking process handles (#603)

Browse Source 
Not closing process handles after using them. Every second. Smh. Imagine. Couldn't be me.
This commit is contained in:
Teacup
2023-07-21 19:32:13 -04:00
committed by GitHub
parent 5ce1ac1279
commit 05efbe376e
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
WinApi.cs
View File

@@ -28,6 +28,8 @@ namespace VRCX
[DllImport("kernel32.dll", SetLastError = true)]
public static extern bool GetExitCodeProcess(IntPtr hProcess, out uint lpExitCode);
[DllImport("kernel32.dll", SetLastError = true)]
public static extern bool CloseHandle(IntPtr hObject);
/// <summary>
/// Flag that specifies the access rights to query limited information about a process.
@@ -54,13 +56,24 @@ namespace VRCX
}
bool exited;
if (!WinApi.GetExitCodeProcess(hProcess, out uint exitCode))
{
throw new System.ComponentModel.Win32Exception(Marshal.GetLastWin32Error());
}
// Fun fact, If a program uses STILL_ACTIVE (259) as an exit code, GetExitCodeProcess will return 259, since it returns... the exit code. This would break this function.
exited = exitCode != 259;
try
{
if (!WinApi.GetExitCodeProcess(hProcess, out uint exitCode))
{
throw new System.ComponentModel.Win32Exception(Marshal.GetLastWin32Error());
}
// Fun fact, If a program uses STILL_ACTIVE (259) as an exit code, GetExitCodeProcess will return 259, since it returns... the exit code. This would break this function.
exited = exitCode != 259;
}
finally
{
// Imagine closing process handles.
WinApi.CloseHandle(hProcess);
}
return exited;
}
}