Proper battery sense fix #295

New Issue

MrUnknownDE · 2026-04-05T17:52:29+02:00

MrUnknownDE commented

2026-04-05 17:52:29 +02:00

Originally created by @Vyolex on 1/24/2023

This commit properly "fixes" the battery sense, in the previous fix I submitted (#139) I simply swapped the R1 and R2 values not noticing that the formula itself was wrong, not the default values.

This rectifies that mistake by swapping the values again and fixing the formula instead. Now it should be consistent with the comments and the actual values inside the datasheet again and should cause less confusion.

This fix is OPTIONAL as it does not change anything relating to the behavior and only tries to improve code readability and consistency.

*Originally created by @Vyolex on 1/24/2023* This commit properly "fixes" the battery sense, in the previous fix I submitted (#139) I simply swapped the R1 and R2 values not noticing that the formula itself was wrong, not the default values. This rectifies that mistake by swapping the values again and fixing the formula instead. Now it should be consistent with the comments and the actual values inside the datasheet again and should cause less confusion. This fix is OPTIONAL as it does not change anything relating to the behavior and only tries to improve code readability and consistency. ![image](https://user-images.githubusercontent.com/25586367/214426139-79c1b257-50d6-46c1-a31e-9435786b56be.png)

MrUnknownDE closed this issue

2026-04-05 17:52:29 +02:00

MrUnknownDE added the Priority: Low Area: Hardware Protocol Priority: Low Priority: Low Priority: Low Priority: Low Area: Hardware Protocol Area: Hardware Protocol Area: Hardware Protocol labels 2026-04-05 17:52:30 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/SlimeVR-Tracker-ESP#295