Move the logic of this check to the sensor class #102

New Issue

MrUnknownDE · 2026-04-05T17:51:50+02:00

MrUnknownDE commented

2026-04-05 17:51:50 +02:00

Originally created by @unlogisch04 on 4/17/2025

The sensor class should tell if the config has been changed.
It would avoid the need for check

		&& sensor->getSensorType() != SensorTypeID::Unknown
		&& sensor->getSensorType() != SensorTypeID::Empty;

The challenge is probably to get the acknowledged back to the sensor.

ee48341c30/src/network/connection.cpp (L516-L522)

*Originally created by @unlogisch04 on 4/17/2025* The sensor class should tell if the config has been changed. It would avoid the need for check ```cpp && sensor->getSensorType() != SensorTypeID::Unknown && sensor->getSensorType() != SensorTypeID::Empty; ``` The challenge is probably to get the acknowledged back to the sensor. https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/ee48341c303e97a2d35eb978311bb682dc1cce9b/src/network/connection.cpp#L516-L522

MrUnknownDE added the Priority: Low Difficulty: Newbie Friendly Type: Enhancement Type: Discussion labels 2026-04-05 17:51:50 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/SlimeVR-Tracker-ESP#102