Compare commits

...

21 Commits

Author SHA1 Message Date
Bas950
b6bad90919 chore: release v0.0.9 2024-09-13 14:33:34 +02:00
Bas950
ee21bb9dec chore: release v0.0.20 2024-09-13 14:31:39 +02:00
Bas950
6efac4fef1 feat: use scienceId 2024-09-13 14:31:27 +02:00
Bas950
93424793bd chore: release v0.0.19 2024-09-13 13:46:33 +02:00
Bas950
affcb6a0cf chore: add reason 2024-09-13 13:46:27 +02:00
Bas950
bb56949dfb chore: release v0.0.18 2024-09-13 13:02:31 +02:00
Bas950
c06fe04b65 chore: fix time 2024-09-13 13:02:26 +02:00
Florian Metz
ef976341ba chore: release v0.0.17 2024-09-13 12:33:19 +02:00
Florian Metz
38893891af chore: why does it not abort 2024-09-13 12:33:10 +02:00
Florian Metz
63eeeefda7 chore: release v0.0.16 2024-09-13 12:05:42 +02:00
Florian Metz
056db21cb0 chore: add p-limit dependency for session cleanup 2024-09-13 12:05:37 +02:00
Bas950
d8dc08c6c3 chore: release v0.0.15 2024-09-13 11:55:36 +02:00
Bas950
634391b6e3 chore: always return the key 2024-09-13 11:55:32 +02:00
Florian Metz
c46cf6975a chore: release v0.0.14 2024-09-13 11:52:23 +02:00
Florian Metz
68c6b4fcdc chore: add p-limit dependency for session cleanup 2024-09-13 11:52:00 +02:00
Florian Metz
55fa07d5b5 chore: release v0.0.13 2024-09-13 11:38:49 +02:00
Florian Metz
903c238b33 chore: add timeout to headless session deletion 2024-09-13 11:38:40 +02:00
Bas950
acd9afb2b1 chore: release v0.0.12 2024-09-13 11:32:55 +02:00
Bas950
4bd42390eb chore: move some code 2024-09-13 11:32:44 +02:00
Florian Metz
c014504464 chore: release v0.0.11 2024-09-13 11:00:16 +02:00
Florian Metz
24fe349b60 chore: optimize session cleanup with batch deletion 2024-09-13 10:59:13 +02:00
5 changed files with 86 additions and 22 deletions

View File

@@ -1,7 +1,7 @@
{
"name": "@premid/api-master",
"type": "module",
"version": "0.0.10",
"version": "0.0.20",
"private": true,
"description": "PreMiD's api master",
"license": "MPL-2.0",
@@ -22,7 +22,8 @@
"@sentry/node": "^8.17.0",
"cron": "^3.1.7",
"debug": "^4.3.6",
"ioredis": "^5.3.2"
"ioredis": "^5.3.2",
"p-limit": "^6.1.0"
},
"devDependencies": {
"@types/debug": "^4.1.12"

View File

@@ -1,4 +1,5 @@
import { REST } from "@discordjs/rest";
import pLimit from "p-limit";
import { mainLog, redis } from "../index.js";
let inProgress = false;
@@ -13,15 +14,20 @@ export async function clearOldSessions() {
let cursor = "0";
let totalSessions = 0;
let cleared = 0;
const batchSize = 100;
let keysToDelete: string[] = [];
mainLog("Starting session cleanup");
const limit = pLimit(100); // Create a limit of 100 concurrent operations
do {
//* Use hscan to iterate through sessions
const [nextCursor, result] = await redis.hscan("pmd-api.sessions", cursor, "COUNT", "100");
const [nextCursor, result] = await redis.hscan("pmd-api.sessions", cursor, "COUNT", batchSize);
cursor = nextCursor;
totalSessions += result.length / 2;
const deletePromises = [];
for (let i = 0; i < result.length; i += 2) {
const key = result[i];
const value = result[i + 1];
@@ -36,29 +42,30 @@ export async function clearOldSessions() {
lastUpdated: number;
};
//* If the session is younger than 30 seconds, skip it
if (now - session.lastUpdated < 30000)
continue;
//* Delete the session
try {
const discord = new REST({ version: "10", authPrefix: "Bearer" });
discord.setToken(session.token);
await discord.post("/users/@me/headless-sessions/delete", {
body: {
token: session.session,
},
});
deletePromises.push(limit(() => deleteSession(session, key)));
}
await redis.hdel("pmd-api.sessions", key);
const results = await Promise.allSettled(deletePromises);
results.forEach((result) => {
if (result.status === "fulfilled" && result.value) {
keysToDelete.push(result.value);
cleared++;
}
catch (error) {
mainLog(`Failed to delete session: %O`, (typeof error === "object" && error && "message" in error ? error.message : error));
}
});
if (keysToDelete.length >= batchSize) {
await redis.hdel("pmd-api.sessions", ...keysToDelete);
keysToDelete = [];
}
} while (cursor !== "0");
if (keysToDelete.length > 0) {
await redis.hdel("pmd-api.sessions", ...keysToDelete);
}
if (totalSessions === 0) {
mainLog("No sessions to clear");
}
@@ -68,3 +75,43 @@ export async function clearOldSessions() {
inProgress = false;
}
async function deleteSession(session: { token: string; session: string }, key: string): Promise<string> {
const abortController = new AbortController();
const timeoutId = setTimeout(() => abortController.abort("Timeout"), 5000); //* 5 second timeout
try {
const discord = new REST({ version: "10", authPrefix: "Bearer" });
discord.setToken(session.token);
await discord.post("/users/@me/headless-sessions/delete", {
signal: abortController.signal,
body: {
token: session.session,
},
});
clearTimeout(timeoutId);
return key;
}
catch (error) {
clearTimeout(timeoutId);
//* Log detailed error information
mainLog(`Delete session error for key ${key}:`, {
errorName: error instanceof Error ? error.name : "Unknown",
errorMessage: error instanceof Error ? error.message : String(error),
errorStack: error instanceof Error ? error.stack : "No stack trace",
});
if (error instanceof Error && error.name === "AbortError") {
mainLog(`Session deletion aborted due to timeout for key ${key}`);
}
else if (error instanceof Error) {
mainLog(`Failed to delete session for key ${key}: ${error.message}`);
}
else {
mainLog(`Failed to delete session for key ${key}: Unknown error`);
}
return key;
}
}

View File

@@ -1,7 +1,7 @@
{
"name": "@premid/api-worker",
"type": "module",
"version": "0.0.8",
"version": "0.0.9",
"private": true,
"description": "PreMiD's api",
"license": "MPL-2.0",

View File

@@ -8,13 +8,17 @@ import { redis } from "../functions/createServer.js";
const schema = type({
token: "string.trim",
session: "string.trim",
version: "string.semver & string.trim",
scienceId: "string.trim",
});
export async function sessionKeepAlive(request: FastifyRequest, reply: FastifyReply) {
//* Get the 2 headers
//* Get the headers
const out = schema({
token: request.headers["x-token"],
session: request.headers["x-session"],
version: request.headers["x-version"] ?? "2.6.8",
scienceId: request.headers["x-science-id"] ?? request.headers["x-token"],
});
if (out instanceof type.errors)
@@ -25,7 +29,7 @@ export async function sessionKeepAlive(request: FastifyRequest, reply: FastifyRe
await redis.hset(
"pmd-api.sessions",
out.token,
out.scienceId,
JSON.stringify({
session: out.session,
token: out.token,

14
pnpm-lock.yaml generated
View File

@@ -80,6 +80,9 @@ importers:
ioredis:
specifier: ^5.3.2
version: 5.4.1
p-limit:
specifier: ^6.1.0
version: 6.1.0
devDependencies:
'@types/debug':
specifier: ^4.1.12
@@ -2956,6 +2959,7 @@ packages:
'@rollup/rollup-linux-arm64-gnu@4.21.2':
resolution: {integrity: sha512-69CF19Kp3TdMopyteO/LJbWufOzqqXzkrv4L2sP8kfMaAQ6iwky7NoXTp7bD6/irKgknDKM0P9E/1l5XxVQAhw==}
cpu: [arm64]
os: [linux]
'@rollup/rollup-linux-arm64-musl@4.18.1':
@@ -6855,6 +6859,10 @@ packages:
resolution: {integrity: sha512-5b0R4txpzjPWVw/cXXUResoD4hb6U/x9BH08L7nw+GN1sezDzPdxeRvpc9c433fZhBan/wusjbCsqwqm4EIBIQ==}
engines: {node: ^12.20.0 || ^14.13.1 || >=16.0.0}
p-limit@6.1.0:
resolution: {integrity: sha512-H0jc0q1vOzlEk0TqAKXKZxdl7kX3OFUzCnNVUnq5Pc3DGo0kpeaMuPqxQn235HibwBEb0/pm9dgKTjXy66fBkg==}
engines: {node: '>=18'}
p-locate@4.1.0:
resolution: {integrity: sha512-R79ZZ/0wAxKGu3oYMlz8jy/kbhsNrS7SKZ7PxEHBgJ5+F2mtFW2fK2cOtBh1cHYkQsbzFV7I+EoRKe6Yt0oK7A==}
engines: {node: '>=8'}
@@ -13506,7 +13514,7 @@ snapshots:
pathe: 1.1.2
sirv: 2.0.4
tinyrainbow: 1.2.0
vitest: 2.0.5(@types/node@22.5.4)(@vitest/ui@2.0.5)(happy-dom@15.0.0)(sass@1.78.0)(terser@5.32.0)
vitest: 2.0.5(@types/node@20.16.5)(@vitest/ui@2.0.5)(happy-dom@15.7.4)(sass@1.78.0)(terser@5.32.0)
'@vitest/utils@2.0.5':
dependencies:
@@ -17895,6 +17903,10 @@ snapshots:
dependencies:
yocto-queue: 1.1.1
p-limit@6.1.0:
dependencies:
yocto-queue: 1.1.1
p-locate@4.1.0:
dependencies:
p-limit: 2.3.0