Bump UVC settings, clean up sdkconfig in preparations for more boards

components/CameraManager/CameraManager/CameraManager.cpp

@@ -75,7 +75,6 @@ void CameraManager::setupCameraPinout()
       .ledc_timer = LEDC_TIMER_0,
       .ledc_channel = LEDC_CHANNEL_0,
 
-      // this causes problems
       .pixel_format = PIXFORMAT_JPEG,  // YUV422,GRAYSCALE,RGB565,JPEG
       .frame_size = FRAMESIZE_240X240, // QQVGA-UXGA, For ESP32, do not use sizes above QVGA when not JPEG. The performance of the ESP32-S series has improved a lot, but JPEG mode always gives better frame rates.
 
@@ -138,7 +137,7 @@ void CameraManager::setupCameraSensor()
   // automatic gain control gain, controls by how much the resulting image
   // should be amplified
   camera_sensor->set_agc_gain(camera_sensor, 2);                   // 0 to 30
-  camera_sensor->set_gainceiling(camera_sensor, (gainceiling_t)6); // 0 to 6
+  camera_sensor->set_gainceiling(camera_sensor, static_cast<gainceiling_t>(6)); // 0 to 6
 
   // black and white pixel correction, averages the white and black spots
   camera_sensor->set_bpc(camera_sensor, 1); // 0 = disable , 1 = enable
@@ -170,9 +169,6 @@ bool CameraManager::setupCamera()
 {
   ESP_LOGI(CAMERA_MANAGER_TAG, "Setting up camera pinout");
   this->setupCameraPinout();
-  ESP_LOGI(CAMERA_MANAGER_TAG, "Setting up camera with resolution");
-  // this->setupBasicResolution();
-
   ESP_LOGI(CAMERA_MANAGER_TAG, "Initializing camera...");
 
   if (auto const hasCameraBeenInitialized = esp_camera_init(&config); hasCameraBeenInitialized == ESP_OK)
@@ -212,7 +208,6 @@ bool CameraManager::setupCamera()
 #endif
 
   this->setupCameraSensor();
-  // this->loadConfigData(); // move this to update method once implemented
   return true;
 }
 

components/CameraManager/CameraManager/CameraManager.hpp

@@ -36,7 +36,6 @@ private:
   void loadConfigData();
   void setupCameraPinout();
   void setupCameraSensor();
-  void setupBasicResolution();
 };
 
 #endif // CAMERAMANAGER_HPP