version is not a valid key of server in the JSON returned from api/config #972

Closed
opened 2026-04-06 01:25:44 +02:00 by MrUnknownDE · 0 comments
Owner

Originally created by @zacknewman on 8/22/2024

Vaultwarden Support String

Not applicable.

Steps To Reproduce

Read source code:

Json(json!({
  // Note: The clients use this version to handle backwards compatibility concerns
  // This means they expect a version that closely matches the Bitwarden server version
  // We should make sure that we keep this updated when we support the new server features
  // Version history:
  // - Individual cipher key encryption: 2023.9.1
  "version": "2024.2.0",
  "gitHash": option_env!("GIT_REV"),
  "server": {
    "name": "Vaultwarden",
    "url": "https://github.com/dani-garcia/vaultwarden",
    "version": crate::VERSION
  },
  "environment": {
    "vault": domain,
    "api": format!("{domain}/api"),
    "identity": format!("{domain}/identity"),
    "notifications": format!("{domain}/notifications"),
    "sso": "",
  },
  "featureStates": feature_states,
  "object": "config",
}))

Expected Result

server to either be null like upstream:

{
  "version":"2024.8.0",
  "gitHash":"47afe973",
  "server":null,
  "environment":{
    "cloudRegion":"US",
    "vault":"https://vault.bitwarden.com",
    "api":"https://api.bitwarden.com",
    "identity":"https://identity.bitwarden.com",
    "notifications":"https://notifications.bitwarden.com",
    "sso":"https://sso.bitwarden.com"
  },
  "featureStates":{
    "display-eu-environment":true,
    "browser-fileless-import":false,
    "return-error-on-existing-keypair":true,
    "use-tree-walker-api-for-page-details-collection":true,
    "flexible-collections-v-1":true,
    "key-rotation-improvements":true,
    "duo-redirect":true,
    "PM-5864-dollar-threshold":true,
    "show-payment-method-warning-banners":false,
    "enable-consolidated-billing":true,
    "AC-1795_updated-subscription-status-section":false,
    "AC-1218-delete-provider":true,
    "email-verification":false,
    "anh-fcmv1-migration":true,
    "extension-refresh":false,
    "restrict-provider-access":true,
    "PM-4154-bulk-encryption-service":true,
    "vault-bulk-management-action":true,
    "bulk-device-approval":true,
    "ac-2059-member-access-report":false,
    "block-legacy-users":false,
    "inline-menu-field-qualification":true,
    "two-factor-component-refactor":false,
    "inline-menu-positioning-improvements":true,
    "AC-2828_provider-portal-members-page":false,
    "ac-2833-provider-client-vault-privacy-banner":false,
    "pm-8285-device-trust-logging":true,
    "authenticator-2fa-token":true,
    "AC-2708-upgrade-password-manager-sub":false,
    "unauth-ui-refresh":false,
    "generate-identity-fill-script-refactor":true,
    "delay-fido2-page-script-init-within-mv2":true,
    "ac-1698-members-two-fa-query-optimization":false
  },
  "object":"config"
}

or to only contain the keys name and url as defined upstream:

public class ServerConfigResponseModel
{
    public string Name { get; set; }
    public string Url { get; set; }
}

Actual Result

server contains a key version.

Screenshots or Videos

No response

Logs

No response

Additional Context

No response

Host/Server Operating System

Linux

Operating System Version

No response

Deployment method

Other method

Custom deployment method

No response

Vaultwarden Build Version

1.32.0

Clients

Web Vault

Client Version

v2024.7.2

*Originally created by @zacknewman on 8/22/2024* ### Vaultwarden Support String Not applicable. ### Steps To Reproduce [Read source code](https://github.com/dani-garcia/vaultwarden/blob/main/src/api/core/mod.rs#L206): ```rust Json(json!({ // Note: The clients use this version to handle backwards compatibility concerns // This means they expect a version that closely matches the Bitwarden server version // We should make sure that we keep this updated when we support the new server features // Version history: // - Individual cipher key encryption: 2023.9.1 "version": "2024.2.0", "gitHash": option_env!("GIT_REV"), "server": { "name": "Vaultwarden", "url": "https://github.com/dani-garcia/vaultwarden", "version": crate::VERSION }, "environment": { "vault": domain, "api": format!("{domain}/api"), "identity": format!("{domain}/identity"), "notifications": format!("{domain}/notifications"), "sso": "", }, "featureStates": feature_states, "object": "config", })) ``` ### Expected Result `server` to either be `null` like upstream: ```json { "version":"2024.8.0", "gitHash":"47afe973", "server":null, "environment":{ "cloudRegion":"US", "vault":"https://vault.bitwarden.com", "api":"https://api.bitwarden.com", "identity":"https://identity.bitwarden.com", "notifications":"https://notifications.bitwarden.com", "sso":"https://sso.bitwarden.com" }, "featureStates":{ "display-eu-environment":true, "browser-fileless-import":false, "return-error-on-existing-keypair":true, "use-tree-walker-api-for-page-details-collection":true, "flexible-collections-v-1":true, "key-rotation-improvements":true, "duo-redirect":true, "PM-5864-dollar-threshold":true, "show-payment-method-warning-banners":false, "enable-consolidated-billing":true, "AC-1795_updated-subscription-status-section":false, "AC-1218-delete-provider":true, "email-verification":false, "anh-fcmv1-migration":true, "extension-refresh":false, "restrict-provider-access":true, "PM-4154-bulk-encryption-service":true, "vault-bulk-management-action":true, "bulk-device-approval":true, "ac-2059-member-access-report":false, "block-legacy-users":false, "inline-menu-field-qualification":true, "two-factor-component-refactor":false, "inline-menu-positioning-improvements":true, "AC-2828_provider-portal-members-page":false, "ac-2833-provider-client-vault-privacy-banner":false, "pm-8285-device-trust-logging":true, "authenticator-2fa-token":true, "AC-2708-upgrade-password-manager-sub":false, "unauth-ui-refresh":false, "generate-identity-fill-script-refactor":true, "delay-fido2-page-script-init-within-mv2":true, "ac-1698-members-two-fa-query-optimization":false }, "object":"config" } ``` or to only contain the keys `name` and `url` as [defined upstream](https://github.com/bitwarden/server/blob/main/src/Api/Models/Response/ConfigResponseModel.cs#L42): ```c# public class ServerConfigResponseModel { public string Name { get; set; } public string Url { get; set; } } ``` ### Actual Result `server` contains a key `version`. ### Screenshots or Videos _No response_ ### Logs _No response_ ### Additional Context _No response_ ### Host/Server Operating System Linux ### Operating System Version _No response_ ### Deployment method Other method ### Custom deployment method _No response_ ### Vaultwarden Build Version 1.32.0 ### Clients Web Vault ### Client Version v2024.7.2
MrUnknownDE added the bugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbugbug labels 2026-04-06 01:27:02 +02:00
Sign in to join this conversation.
No Label bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/vaultwarden#972