Fix compiling for Windows targets #891

New Issue

MrUnknownDE · 2026-04-06T00:28:04+02:00

MrUnknownDE commented

2026-04-06 00:28:04 +02:00

Originally created by @BlackDex on 10/6/2024

The unix::signal was also included during Windows compilations. This of course will not work. Fix this by only including it for unix targets.

Also changed all other conditional compilation options to use cfg(unix) instead of cfg(not(windows)). The latter may also include wasm for example, or any other future target family. This way we will only match unix

Fixes #5052

*Originally created by @BlackDex on 10/6/2024* The `unix::signal` was also included during Windows compilations. This of course will not work. Fix this by only including it for `unix` targets. Also changed all other conditional compilation options to use `cfg(unix)` instead of `cfg(not(windows))`. The latter may also include `wasm` for example, or any other future target family. This way we will only match `unix` Fixes #5052

MrUnknownDE closed this issue

2026-04-06 00:28:04 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#891