Fix favicon fetching to check all icon links instead of just the first one #88

New Issue

MrUnknownDE · 2026-04-05T20:29:50+02:00

MrUnknownDE commented

2026-04-05 20:29:50 +02:00

Originally created by @Shocker on 2/27/2026

Fix logic in download_icon(), got broken (most likely accidentally) in 27dc67fadd (diff-c0f730ed83eb02623c5c9bde35b0366115b8961fb596c27f98613140cba6d2a7L714) which caused the downloader to stop after first error

~~Also don't limit max checked icons to 5, allow all icons in the list~~

*Originally created by @Shocker on 2/27/2026* Fix logic in `download_icon()`, got broken (most likely accidentally) in https://github.com/dani-garcia/vaultwarden/commit/27dc67fadd3d45b9f7d8d37407cef9453b8f5802#diff-c0f730ed83eb02623c5c9bde35b0366115b8961fb596c27f98613140cba6d2a7L714 which caused the downloader to stop after first error ~~Also don't limit max checked icons to 5, allow all icons in the list~~

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#88