Fix Yubico toggle #578

New Issue

MrUnknownDE · 2026-04-05T21:56:40+02:00

MrUnknownDE commented

2026-04-05 21:56:40 +02:00

Originally created by @Timshel on 5/5/2025

While testing the toggle for https://github.com/dani-garcia/vaultwarden/pull/5832

Realized that with the current logic Yubico is considered enabled when both client and secret are not set.
The provider is then visible but trying to enable it will result in the failure:

Cf: yubikey.rs#L69

*Originally created by @Timshel on 5/5/2025* While testing the toggle for https://github.com/dani-garcia/vaultwarden/pull/5832 Realized that with the current logic Yubico is considered enabled when both client and secret are not set. The provider is then visible but trying to enable it will result in the failure: ![yubico](https://github.com/user-attachments/assets/80719abf-dfcd-442d-8c3b-86bdb976e730) Cf: [yubikey.rs#L69](https://github.com/dani-garcia/vaultwarden/blob/2697fe8aba9b082aca02b48990bc65e9fc526aa4/src/api/core/two_factor/yubikey.rs#L69)

MrUnknownDE closed this issue

2026-04-05 21:56:40 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#578