a little cleanup after SSO merge #427

New Issue

MrUnknownDE · 2026-04-05T21:13:43+02:00

MrUnknownDE commented

2026-04-05 21:13:43 +02:00

Originally created by @stefan0xC on 8/9/2025

A few things I noticed while reviewing the changes (that were still pending). Mostly some typos in the comments and some function names. I've also moved the is_mobile() to the Device to be more like the is_cli() check and I think it would be better if the scss variable is called sso_enabled instead of sso_disabled because to me it's easier to reason about that way.

I'm also planning on working on the playwright setup (as discussed in #4369) and maybe some more refactoring of the code base now that it has been merged.

*Originally created by @stefan0xC on 8/9/2025* A few things I noticed while reviewing the changes (that were still pending). Mostly some typos in the comments and some function names. I've also moved the `is_mobile()` to the `Device` to be more like the `is_cli()` check and I think it would be better if the scss variable is called `sso_enabled` instead of `sso_disabled` because to me it's easier to reason about that way. I'm also planning on working on the playwright setup (as discussed in #4369) and maybe some more refactoring of the code base now that it has been merged.

MrUnknownDE closed this issue

2026-04-05 21:13:43 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#427