Restrict join on users_collections to current user (fixes #313) #3624

New Issue

MrUnknownDE · 2026-04-06T05:08:33+02:00

MrUnknownDE commented

2026-04-06 05:08:33 +02:00

Originally created by @aksdb on 12/28/2018

It fixes #313 at least partially ... the other part being fixed by @mprasil's PR #314.

The problem was, that when multiple users in the same collection are Admin or Owner, the previous JOIN would include multiple rows for the same cipher. The PR fixes this by restricting the joined users_collections in the first place.
(It also makes another JOIN a little more explicit.)

*Originally created by @aksdb on 12/28/2018* It fixes #313 at least partially ... the other part being fixed by @mprasil's PR #314. The problem was, that when multiple users in the same collection are Admin or Owner, the previous JOIN would include multiple rows for the same cipher. The PR fixes this by restricting the joined users_collections in the first place. (It also makes another JOIN a little more explicit.)

MrUnknownDE closed this issue

2026-04-06 05:08:33 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#3624