Fix icon redirect caching #271

New Issue

MrUnknownDE · 2026-04-05T20:45:39+02:00

MrUnknownDE commented

2026-04-05 20:45:39 +02:00

Originally created by @BlackDex on 11/23/2025

As reported in #6477, redirection of favicon's didn't allowed caching. This commit fixes this by adding the Cached wrapper around the response. It will use the same TTL's used for downloading icon's locally.

Also removed _ as valid domain character, these should not be used in FQDN's at all. Those only serve as special chars used in domain labels, mostly used in SRV or TXT records.

Fixes #6477

*Originally created by @BlackDex on 11/23/2025* As reported in #6477, redirection of favicon's didn't allowed caching. This commit fixes this by adding the `Cached` wrapper around the response. It will use the same TTL's used for downloading icon's locally. Also removed `_` as valid domain character, these should not be used in FQDN's at all. Those only serve as special chars used in domain labels, mostly used in SRV or TXT records. Fixes #6477

MrUnknownDE closed this issue

2026-04-05 20:45:39 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#271