Add more clippy checks for better code/readability #2060

New Issue

MrUnknownDE · 2026-04-06T02:54:36+02:00

MrUnknownDE commented

2026-04-06 02:54:36 +02:00

Originally created by @BlackDex on 7/10/2022

A bit inspired by @paolobarbolini from this commit at lettre https://github.com/lettre/lettre/pull/784 .
I added a few more clippy lints here, and fixed the resulted issues.

Overall i think this could help in preventing future issues, and maybe
even peformance problems. It also makes some code a bit more clear.

We could always add more if we want to, i left a few out which i think
arn't that huge of an issue. Some like the unused_async are nice,
which resulted in a few async removals.

Some others are maybe a bit more estatic, like string_to_string, but i
think it looks better to use clone in those cases instead of to_string while they already are a string.

*Originally created by @BlackDex on 7/10/2022* A bit inspired by @paolobarbolini from this commit at lettre https://github.com/lettre/lettre/pull/784 . I added a few more clippy lints here, and fixed the resulted issues. Overall i think this could help in preventing future issues, and maybe even peformance problems. It also makes some code a bit more clear. We could always add more if we want to, i left a few out which i think arn't that huge of an issue. Some like the `unused_async` are nice, which resulted in a few `async` removals. Some others are maybe a bit more estatic, like `string_to_string`, but i think it looks better to use `clone` in those cases instead of `to_string` while they already are a string.

MrUnknownDE closed this issue

2026-04-06 02:54:36 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#2060