Prevent DNS leak when icon regex is configured #1906

New Issue

MrUnknownDE · 2026-04-06T02:39:29+02:00

MrUnknownDE commented

2026-04-06 02:39:29 +02:00

Originally created by @BlackDex on 11/14/2022

When a icon blacklist regex was configured to not check for a domain, it still did a DNS lookup first. This could cause a DNS leakage for these regex blocked domains.

This PR resolves this issue by first checking the regex, and afterwards the other checks.

Fixes #2909

Also updated the fallback icon to the latest version used by Bitwarden it self.

*Originally created by @BlackDex on 11/14/2022* When a icon blacklist regex was configured to not check for a domain, it still did a DNS lookup first. This could cause a DNS leakage for these regex blocked domains. This PR resolves this issue by first checking the regex, and afterwards the other checks. Fixes #2909 Also updated the fallback icon to the latest version used by Bitwarden it self.

MrUnknownDE closed this issue

2026-04-06 02:39:29 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#1906