improve sso callback path #176

New Issue

MrUnknownDE · 2026-04-05T20:34:58+02:00

MrUnknownDE commented

2026-04-05 20:34:58 +02:00

Originally created by @stefan0xC on 1/6/2026

Currently we remove a trailing slash after making the config:
9f1df42259/src/config.rs (L309)

This means that the generated sso_callback_path is not yet normalized, which leads to some issues (e.g. https://github.com/dani-garcia/vaultwarden/issues/6180 or https://github.com/dani-garcia/vaultwarden/issues/6601).

This change would fix that by applying the same normalization to the generated URL.

*Originally created by @stefan0xC on 1/6/2026* Currently we remove a trailing slash after making the config: https://github.com/dani-garcia/vaultwarden/blob/9f1df422595cdfb04b8aea6968ae52a434887abc/src/config.rs#L309 This means that the generated `sso_callback_path` is not yet normalized, which leads to some issues (e.g. https://github.com/dani-garcia/vaultwarden/issues/6180 or https://github.com/dani-garcia/vaultwarden/issues/6601). This change would fix that by applying the same normalization to the generated URL.

MrUnknownDE closed this issue

2026-04-05 20:34:58 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#176