Not considering the situation when the user domain name starts with “admin”. #1659

New Issue

MrUnknownDE · 2026-04-06T02:07:58+02:00

MrUnknownDE commented

2026-04-06 02:07:58 +02:00

Originally created by @fxzxmic on 4/3/2023

Subject of the issue

The file "admin.js" contains the following code:

function getBaseUrl() {
    // If the base URL is `https://vaultwarden.example.com/base/path/`,
    // `window.location.href` should have one of the following forms:
    //
    // - `https://vaultwarden.example.com/base/path/`
    // - `https://vaultwarden.example.com/base/path/#/some/route[?queryParam=...]`
    //
    // We want to get to just `https://vaultwarden.example.com/base/path`.
    const baseUrl = window.location.href;
    const adminPos = baseUrl.indexOf("/admin");
    return baseUrl.substring(0, adminPos != -1 ? adminPos : baseUrl.length);
}

If the domain name is abc.com, the function returns https://abc.com.
But if the domain name is admin.abc.com or just adminxxx.com, the function returns https:/. This is not the expected value.

Additional statements

In addition, I hope you can consider the following discussion when fixing this issue. It is possible not to provide relevant functions, but please do not undermine the currently feasible workarounds.
https://github.com/dani-garcia/vaultwarden/discussions/1494#discussioncomment-5511696

If my domain name is abc.com, in my use case, my background address is https://admin.abc.com/vault.

*Originally created by @fxzxmic on 4/3/2023*   ### Subject of the issue  The file "admin.js" contains the following code: ``` function getBaseUrl() { // If the base URL is `https://vaultwarden.example.com/base/path/`, // `window.location.href` should have one of the following forms: // // - `https://vaultwarden.example.com/base/path/` // - `https://vaultwarden.example.com/base/path/#/some/route[?queryParam=...]` // // We want to get to just `https://vaultwarden.example.com/base/path`. const baseUrl = window.location.href; const adminPos = baseUrl.indexOf("/admin"); return baseUrl.substring(0, adminPos != -1 ? adminPos : baseUrl.length); } ``` If the domain name is `abc.com`, the function returns `https://abc.com`. But if the domain name is `admin.abc.com` or just `adminxxx.com`, the function returns `https:/`. This is not the expected value. ### Additional statements In addition, I hope you can consider the following discussion when fixing this issue. It is possible not to provide relevant functions, but please do not undermine the currently feasible workarounds. https://github.com/dani-garcia/vaultwarden/discussions/1494#discussioncomment-5511696 If my domain name is `abc.com`, in my use case, my background address is `https://admin.abc.com/vault`.

MrUnknownDE closed this issue

2026-04-06 02:07:58 +02:00

Sign in to join this conversation.

No Label bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug bug enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#1659