Change String to &str for all Rocket functions and some other fixes #1626

New Issue

MrUnknownDE · 2026-04-06T02:06:28+02:00

MrUnknownDE commented

2026-04-06 02:06:28 +02:00

Originally created by @BlackDex on 4/30/2023

During setting the latest commit hash for Rocket and updating all the other crates, there were some messages regarding the usage of String for the Rocket endpoint function calls.
I acted upon this message and changed all String types to &str and modified the code where needed.

This ended up in less alloc calls, and probably also a bit less memory usage.

Updated all the crates and commit hashes
Modified all String to &str where applicable
Prevent some ::_ logs from outputting
Added some extra routes to be logged
Fix some admin post endpoints

*Originally created by @BlackDex on 4/30/2023* During setting the latest commit hash for Rocket and updating all the other crates, there were some messages regarding the usage of `String` for the Rocket endpoint function calls. I acted upon this message and changed all `String` types to `&str` and modified the code where needed. This ended up in less `alloc` calls, and probably also a bit less memory usage. - Updated all the crates and commit hashes - Modified all `String` to `&str` where applicable - Prevent some `::_` logs from outputting - Added some extra routes to be logged - Fix some admin post endpoints

MrUnknownDE closed this issue

2026-04-06 02:06:28 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#1626

Change String to &str for all Rocket functions and some other fixes #1626

Change `String` to `&str` for all Rocket functions and some other fixes #1626