Multiple domains support #1454

New Issue

MrUnknownDE · 2026-04-06T01:54:36+02:00

MrUnknownDE commented

2026-04-06 01:54:36 +02:00

Originally created by @BlockListed on 9/9/2023

Fixes #2690

Very WIP PR, I just want some feedback about my approach for now.

I am planning to go with the allowed domains approach.

Overview:

~~We create 2 Hashmaps, which map the Host header to either Domain or Origin.~~
We create a hashmap, which maps the Host header to a combination of Domain and Origin.

Limitations:

All domains have to have the same path, because otherwise we would need one web server instance for each different path.

Future:
~~- Change JWT system to create tokens, which work for a single domain.~~

*Originally created by @BlockListed on 9/9/2023* Fixes #2690 Very WIP PR, I just want some feedback about my approach for now. I am planning to go with the allowed domains approach. Overview: - ~~We create 2 Hashmaps, which map the Host header to either Domain or Origin.~~ - We create a hashmap, which maps the Host header to a combination of Domain and Origin. Limitations: - All domains have to have the same path, because otherwise we would need one web server instance for each different path. Future: ~~- Change JWT system to create tokens, which work for a single domain.~~

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#1454