Use async verify for Yubikey #1183

Closed
opened 2026-04-06 01:41:23 +02:00 by MrUnknownDE · 0 comments
Owner

Originally created by @dani-garcia on 3/23/2024

While looking through the crates that we have that use reqwest 0.11, I discovered that the yubico crate can do async verification, so we can avoid the spawn_blocking. I've also changed the error handling a bit to properly log any returned errors.

I've tried it with my yubikeys and seems to work fine.

*Originally created by @dani-garcia on 3/23/2024* While looking through the crates that we have that use reqwest 0.11, I discovered that the yubico crate can do async verification, so we can avoid the spawn_blocking. I've also changed the error handling a bit to properly log any returned errors. I've tried it with my yubikeys and seems to work fine.
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/vaultwarden#1183