Fix subdomain preservation in DomainPicker when switching base domains #987

New Issue

MrUnknownDE · 2026-04-05T18:04:54+02:00

MrUnknownDE commented

2026-04-05 18:04:54 +02:00

Originally created by @arevindh on 8/29/2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

When a user typed a subdomain and then selected a different base domain, the subdomain value was being cleared due to onDomainChange being called with subdomain: undefined.

How to test?

User need to to have more than 1 domain to test.
Type subdomain first then change the base domain.
If the subdomain is valid for the new base domain, the subdomain should be preserved

This should be tested on Create Resource Page and General Section of Resource Settings

*Originally created by @arevindh on 8/29/2025* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description When a user typed a subdomain and then selected a different base domain, the subdomain value was being cleared due to `onDomainChange` being called with `subdomain: undefined`. ## How to test? - User need to to have more than 1 domain to test. - Type subdomain first then change the base domain. - If the subdomain is valid for the new base domain, the subdomain should be preserved This should be tested on **Create Resource Page** and **General Section** of **Resource Settings**

MrUnknownDE closed this issue

2026-04-05 18:04:54 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#987