Fix inconsistent destinationIp validation between create and update APIs #948

New Issue

MrUnknownDE · 2026-04-05T18:02:51+02:00

MrUnknownDE commented

2026-04-05 18:02:51 +02:00

Originally created by @Pallavikumarimdb on 9/7/2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR resolves the inconsistency reported in #1419 and #1426 where the update site resource rejected hostnames (localhost, host.docker.internal, etc.) due to strict .ip() validation, while the create API accepted them.

How to test?

*Originally created by @Pallavikumarimdb on 9/7/2025* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR resolves the inconsistency reported in #1419 and #1426 where the update site resource rejected hostnames (localhost, host.docker.internal, etc.) due to strict .ip() validation, while the create API accepted them. ## How to test?

MrUnknownDE closed this issue

2026-04-05 18:02:51 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#948