fix: show informative message when saving with no targets #63

New Issue

MrUnknownDE · 2026-04-05T17:00:47+02:00

MrUnknownDE commented

2026-04-05 17:00:47 +02:00

Originally created by @jaydeep-pipaliya on 3/25/2026

Summary

When saving targets with an empty target list and no removals, the app previously showed a misleading "Settings updated" success notification
Now shows "No targets to save — Please add at least one target before saving" instead
Added translation keys targetNoTargets and targetNoTargetsDescription to en-US.json

Fixes #586

Test plan

Navigate to a resource's proxy settings
Without adding any targets, click "Save Targets"
Verify the toast says "No targets to save" instead of "Settings updated"
Add a target, save, and verify "Settings updated" still shows correctly
Remove all targets and save — verify deletions still process correctly

*Originally created by @jaydeep-pipaliya on 3/25/2026* ## Summary - When saving targets with an empty target list and no removals, the app previously showed a misleading "Settings updated" success notification - Now shows "No targets to save — Please add at least one target before saving" instead - Added translation keys `targetNoTargets` and `targetNoTargetsDescription` to `en-US.json` Fixes #586 ## Test plan - [ ] Navigate to a resource's proxy settings - [ ] Without adding any targets, click "Save Targets" - [ ] Verify the toast says "No targets to save" instead of "Settings updated" - [ ] Add a target, save, and verify "Settings updated" still shows correctly - [ ] Remove all targets and save — verify deletions still process correctly

MrUnknownDE closed this issue

2026-04-05 17:00:47 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#63