Reset hcHealth to "unknown" when health check is disabled #612

New Issue

MrUnknownDE · 2026-04-05T17:26:50+02:00

MrUnknownDE commented

2026-04-05 17:26:50 +02:00

Originally created by @Copilot on 11/20/2025

When disabling a target's health check via updateTarget, the hcHealth status remains at its previous value (e.g., "unhealthy"). This causes previously unhealthy targets to stay excluded from serving traffic even after health checking is turned off.

Changes

Set hcHealth to "unknown" when hcEnabled is set to false or null
Uses conditional spread to only update hcHealth when health check is being disabled

// When health check is disabled, reset hcHealth to "unknown"
const hcHealthValue = (parsedBody.data.hcEnabled === false || parsedBody.data.hcEnabled === null) 
    ? "unknown" 
    : undefined;

const [updatedHc] = await db
    .update(targetHealthCheck)
    .set({
        hcEnabled: parsedBody.data.hcEnabled || false,
        // ... other fields
        ...(hcHealthValue !== undefined && { hcHealth: hcHealthValue })
    })
    .where(eq(targetHealthCheck.targetId, targetId))
    .returning();

Fixes #1865

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

fonts.googleapis.com

Triggering command: node /home/REDACTED/work/pangolin/pangolin/node_modules/.bin/next build (dns block)

scarf.sh

Triggering command: node ./report.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled

Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

On updateTarget.ts, When the health check is disabled it should set the hcHealth status to the string "unknown" because if it was previously unhealthy you dont want to keep preventing serving the resource.

Reference #1865

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

*Originally created by @Copilot on 11/20/2025* When disabling a target's health check via `updateTarget`, the `hcHealth` status remains at its previous value (e.g., "unhealthy"). This causes previously unhealthy targets to stay excluded from serving traffic even after health checking is turned off. ## Changes - Set `hcHealth` to "unknown" when `hcEnabled` is set to `false` or `null` - Uses conditional spread to only update `hcHealth` when health check is being disabled ```typescript // When health check is disabled, reset hcHealth to "unknown" const hcHealthValue = (parsedBody.data.hcEnabled === false || parsedBody.data.hcEnabled === null) ? "unknown" : undefined; const [updatedHc] = await db .update(targetHealthCheck) .set({ hcEnabled: parsedBody.data.hcEnabled || false, // ... other fields ...(hcHealthValue !== undefined && { hcHealth: hcHealthValue }) }) .where(eq(targetHealthCheck.targetId, targetId)) .returning(); ``` Fixes #1865 > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `fonts.googleapis.com` > - Triggering command: `node /home/REDACTED/work/pangolin/pangolin/node_modules/.bin/next build` (dns block) > - `scarf.sh` > - Triggering command: `node ./report.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/fosrl/pangolin/settings/copilot/coding_agent) (admins only) > > </details>  <details> <summary>Original prompt</summary> > On updateTarget.ts, When the health check is disabled it should set the hcHealth status to the string "unknown" because if it was previously unhealthy you dont want to keep preventing serving the resource. > > Reference #1865 </details>  --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

MrUnknownDE closed this issue

2026-04-05 17:26:50 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#612