Fix: confirm delete button working without confirm text #427

New Issue

MrUnknownDE · 2026-04-05T17:09:46+02:00

MrUnknownDE commented

2026-04-05 17:09:46 +02:00

Originally created by @ruxenburg on 12/27/2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR prevents deletions unless the required confirmation text has been entered. (this has been tested on chrome and Firefox browser)

How to test?

add anything deletable that would trigger the \src\components\ConfirmDeleteDialog.tsx
attempt to delete it without the confirm text (should not work anymore)
attempt it with wrong text (should not work)
attempt it with correct text (should work)

ui changes

ui changes [before]

ui changes [after]

*Originally created by @ruxenburg on 12/27/2025* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR prevents deletions unless the required confirmation text has been entered. (this has been tested on chrome and Firefox browser) ## How to test? 1. add anything deletable that would trigger the `\src\components\ConfirmDeleteDialog.tsx` 2. attempt to delete it without the confirm text (should not work anymore) 3. attempt it with wrong text (should not work) 4. attempt it with correct text (should work) ## ui changes ### ui changes [before] <img width="779" height="637" alt="image" src="https://github.com/user-attachments/assets/249f817c-cd04-44a8-9b9c-5053809574e9" /> ### ui changes [after] <img width="777" height="635" alt="image" src="https://github.com/user-attachments/assets/0c94f9a2-b381-4487-94bb-88bcf97488d5" /> <img width="788" height="648" alt="image" src="https://github.com/user-attachments/assets/f1e595b5-762d-4164-b2c3-9572c3f7682a" />

MrUnknownDE closed this issue

2026-04-05 17:09:46 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#427