fix: show contextual toast when saving with no targets #32

New Issue

MrUnknownDE · 2026-04-05T17:00:35+02:00

MrUnknownDE commented

2026-04-05 17:00:35 +02:00

Originally created by @jaydeep-pipaliya on 3/31/2026

Summary

Follow-up to #2711 based on maintainer feedback — saving with no targets should still work (to allow clearing targets), but the notification should reflect what actually happened.

What changed: Instead of always showing "Settings updated" when saving, the toast now shows:

"Targets cleared" when the target list is empty
"Settings updated" when targets were actually saved

No save action is blocked — this only changes the notification text.

Fixes #586

Test plan

Save with no targets → toast says "Targets cleared"
Save with targets → toast says "Settings updated"
Remove all targets and save → deletions process correctly, toast says "Targets cleared"

*Originally created by @jaydeep-pipaliya on 3/31/2026* ## Summary Follow-up to #2711 based on maintainer feedback — saving with no targets should still work (to allow clearing targets), but the notification should reflect what actually happened. **What changed:** Instead of always showing "Settings updated" when saving, the toast now shows: - **"Targets cleared"** when the target list is empty - **"Settings updated"** when targets were actually saved No save action is blocked — this only changes the notification text. Fixes #586 ## Test plan - [x] Save with no targets → toast says "Targets cleared" - [x] Save with targets → toast says "Settings updated" - [x] Remove all targets and save → deletions process correctly, toast says "Targets cleared"

MrUnknownDE closed this issue

2026-04-05 17:00:35 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#32