Add option to customise TLS server name in resource settings #1621

New Issue

MrUnknownDE · 2026-04-05T19:37:46+02:00

MrUnknownDE commented

2026-04-05 19:37:46 +02:00

Originally created by @achtnullzwei on 4/9/2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Added an option to set a custom TLS Server Name to solve the issue with strict SNI checks. I have added it to the "General" page in Resource settings. Couldn't rly think of a better place, and didn't want to create a new section for it. Also it doesn't make sense to set this on target level. Happy to adjust if needed.

Usage:

In general page of the resource settings, add the desired domain name to the new field TLS Server Name. Save.
To remove it, simply empty the field and save again.
Value entered is checked against meaningful entries.

Value is stored in the resource table in a new column names tlsServerName. Hence, this would require to be covered in the migration scripts. I added a draft migration for future version 1.3.0 as a suggestion.

Screenshot:

Notes:
This is my very first contribution to any project on Github. I usually just work on my own project, but I felt I would like to contribute and get this feature implemented. In any case, I am kindly asking for some patience, if I did sth wrong. I am not rly used to write TS, but it was a lot of fun trying to understand the language a bit more, the code you created and add a feature to it. With respect to the pull request, I saw in the contribution guidelines, that contributions are supposed to be added to main branch. However, my changes would probably break without altering the database and having migration scripts properly added. I added a draft for that at least. Furthermore, I saw some recent pull requests made against dev branch. I hope that's ok. Otherwise, I can change it to the main branch.

How to test?

Build from sources and use docker image. I did test this as extensively as I could and can validate it works, at least in my homelab. I did test it on a live VPS with whoami containers and multiple levels of cascaded reverse-proxies. Also checked for UI issues as much as I can.

*Originally created by @achtnullzwei on 4/9/2025* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Added an option to set a custom TLS Server Name to solve the issue with strict SNI checks. I have added it to the "General" page in Resource settings. Couldn't rly think of a better place, and didn't want to create a new section for it. Also it doesn't make sense to set this on target level. Happy to adjust if needed. Usage: - In general page of the resource settings, add the desired domain name to the new field TLS Server Name. Save. - To remove it, simply empty the field and save again. - Value entered is checked against meaningful entries. Value is stored in the resource table in a new column names tlsServerName. Hence, this would require to be covered in the migration scripts. I added a draft migration for future version 1.3.0 as a suggestion. Screenshot: ![432051205-ae8a5dea-bde4-4ffd-9f3f-b989e59af1e5](https://github.com/user-attachments/assets/9fed0a97-9b55-4aca-bb85-69091881b9dc) Notes: This is my very first contribution to any project on Github. I usually just work on my own project, but I felt I would like to contribute and get this feature implemented. In any case, I am kindly asking for some patience, if I did sth wrong. I am not rly used to write TS, but it was a lot of fun trying to understand the language a bit more, the code you created and add a feature to it. With respect to the pull request, I saw in the contribution guidelines, that contributions are supposed to be added to main branch. However, my changes would probably break without altering the database and having migration scripts properly added. I added a draft for that at least. Furthermore, I saw some recent pull requests made against dev branch. I hope that's ok. Otherwise, I can change it to the main branch. ## How to test? Build from sources and use docker image. I did test this as extensively as I could and can validate it works, at least in my homelab. I did test it on a live VPS with whoami containers and multiple levels of cascaded reverse-proxies. Also checked for UI issues as much as I can.

MrUnknownDE closed this issue

2026-04-05 19:37:46 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#1621