[gerbil]: Never online sites default to listenPort 0 #152

New Issue

MrUnknownDE · 2026-04-05T17:01:38+02:00

MrUnknownDE commented

2026-04-05 17:01:38 +02:00

Originally created by @LaurenceJJones on 3/5/2026

Sites push which port and address they are listening on to Pangolin, if the site never comes online the listenPort is not configured within the database so:

483d54a9f0/server/lib/rebuildClientAssociations.ts (L580-L583)

will default the or condition to 0 which then triggers a gerbil error since nothing can bind to port 0 gerbil correctly expects a listenPort > 0.

ERROR: 2026/03/05 11:10:51 Destination port must be a positive integer for destination 4
ERROR: 2026/03/05 11:10:52 Destination port must be a positive integer for destination 4

User deleted the never online site from discussion below and it fixed the intermediate problem for them but we need to ensure that either we filter the status of the site before mapping the destinations or we simply do not define a or condition of 0.

or if we do allow an or condition of 0 then gerbil can smartly ignore these entries.

Discussed in https://github.com/orgs/fosrl/discussions/2604

*Originally created by @LaurenceJJones on 3/5/2026* Sites push which port and address they are listening on to Pangolin, if the site never comes online the `listenPort` is not configured within the database so: https://github.com/fosrl/pangolin/blob/483d54a9f04572a13cbee4e49ac7006823a1c949/server/lib/rebuildClientAssociations.ts#L580-L583 will default the `or` condition to `0` which then triggers a gerbil error since nothing can bind to port `0` gerbil correctly expects a listenPort `> 0`. ``` ERROR: 2026/03/05 11:10:51 Destination port must be a positive integer for destination 4 ERROR: 2026/03/05 11:10:52 Destination port must be a positive integer for destination 4 ``` User deleted the never online site from discussion below and it fixed the intermediate problem for them but we need to ensure that either we filter the status of the site before mapping the destinations or we simply do not define a `or` condition of `0`. or if we do allow an or condition of `0` then gerbil can smartly ignore these entries. Discussed in https://github.com/orgs/fosrl/discussions/2604

MrUnknownDE closed this issue

2026-04-05 17:01:38 +02:00

MrUnknownDE added the needs investigating needs investigating labels 2026-04-05 17:01:38 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label needs investigating needs investigating

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#152