fix(newt): missing hcStatus in hc config on reconnect #143

New Issue

MrUnknownDE · 2026-04-05T17:01:27+02:00

MrUnknownDE commented

2026-04-05 17:01:27 +02:00

Originally created by @LaurenceJJones on 3/7/2026

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

The buildTargetConfigurationForNewtClient function was not including the
hcStatus field when building health check targets for the newt/wg/connect
message. This caused custom expected response codes (e.g., 409) to revert
to the default 2xx range check after Pangolin server restart.

Added hcStatus to both the database select query and the returned health
check target object, matching the behavior in targets.ts addTargets.

fixes: https://github.com/fosrl/newt/issues/240

How to test?

Follow the steps defined in https://github.com/fosrl/newt/issues/240, after this change the expected code should function correctly.

*Originally created by @LaurenceJJones on 3/7/2026* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description The buildTargetConfigurationForNewtClient function was not including the hcStatus field when building health check targets for the newt/wg/connect message. This caused custom expected response codes (e.g., 409) to revert to the default 2xx range check after Pangolin server restart. Added hcStatus to both the database select query and the returned health check target object, matching the behavior in targets.ts addTargets. fixes: https://github.com/fosrl/newt/issues/240 ## How to test? Follow the steps defined in https://github.com/fosrl/newt/issues/240, after this change the expected code should function correctly.

MrUnknownDE closed this issue

2026-04-05 17:01:27 +02:00

MrUnknownDE referenced this issue

2026-04-05 19:41:58 +02:00

Rules #1794

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#143