Skip invalid Docker resources instead of failing entire blueprint (#1784) #142

New Issue

MrUnknownDE · 2026-04-05T17:01:27+02:00

MrUnknownDE commented

2026-04-05 17:01:27 +02:00

Originally created by @LunarECL on 3/8/2026

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Fixes #1784

If one Docker container had bad labels (like missing a port on a container with no EXPOSE), it would block every other container from updating too. Not great.

Now there's a per-resource pre-validation step in applyNewtDockerBlueprint.ts that catches invalid resources and filters them out before they hit applyBlueprint(). Valid ones still go through the normal ConfigSchema validation, so cross-resource checks like domain/port/alias uniqueness work the same as before. Invalid ones just get logged with the Zod error path and skipped.

Only touched server/lib/blueprints/applyNewtDockerBlueprint.ts. Everything else (applyBlueprint.ts, types.ts, parseDockerContainers.ts) is unchanged.

How to test?

Set up two Docker services with Pangolin labels on the same Docker socket
Remove the port label from one service that has no EXPOSE directive
Update a label on the other (valid) service
Before fix: Both services fail to update. Log shows Validation error: Required at "proxy-resources.testservice.targets[0].port"
After fix: Valid service updates normally. Invalid service gets skipped with a warning: Skipping invalid Docker proxy-resources "testservice": targets.0.port: RequiredRequired`

*Originally created by @LunarECL on 3/8/2026* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Fixes #1784 If one Docker container had bad labels (like missing a port on a container with no EXPOSE), it would block every other container from updating too. Not great. Now there's a per-resource pre-validation step in `applyNewtDockerBlueprint.ts` that catches invalid resources and filters them out before they hit `applyBlueprint()`. Valid ones still go through the normal `ConfigSchema` validation, so cross-resource checks like domain/port/alias uniqueness work the same as before. Invalid ones just get logged with the Zod error path and skipped. Only touched `server/lib/blueprints/applyNewtDockerBlueprint.ts`. Everything else (`applyBlueprint.ts`, `types.ts`, `parseDockerContainers.ts`) is unchanged. ## How to test? 1. Set up two Docker services with Pangolin labels on the same Docker socket 2. Remove the `port` label from one service that has no `EXPOSE` directive 3. Update a label on the other (valid) service 4. **Before fix:** Both services fail to update. Log shows `Validation error: Required at "proxy-resources.testservice.targets[0].port"` 5. **After fix:** Valid service updates normally. Invalid service gets skipped with a warning: `Skipping invalid Docker proxy-resources "testservice": targets.0.port: Required`Required`

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#142