Automate Linting, change linting slightly, and fix semi colon errors. #1376

New Issue

MrUnknownDE · 2026-04-05T19:16:32+02:00

MrUnknownDE commented

2026-04-05 19:16:32 +02:00

Originally created by @thijsvanloef on 6/9/2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR continues the work started in #876, focusing on automating TypeScript linting.

Key changes:

The TypeScript linter now runs automatically on every PR only if TypeScript files are modified.
Replaces the previous, stricter ruleset with a much more lenient configuration.
- This configuration allows for the addition of rules slowly, instead of "everything all at once"
Removes the "typescript recommended" ruleset.
Currently, only semicolon-related issues are treated as errors.
@typescript-eslint/no-unused-vars is now treated as a warning to avoid blocking this PR. Once those warnings are resolved across the codebase, we plan to elevate it to an error level.
Auto-fixed most existing semicolon-related issues for consistency.

How to test?

Create or update a PR that modifies .ts or .tsx files.
Confirm that the linter runs automatically via GitHub Actions.
Ensure the CI only fails on semicolon issues, not on unused variable warnings.

P.S. If you have any more requests on DevOps/automation work, please let me know, I'll be happy to help :)

*Originally created by @thijsvanloef on 6/9/2025* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR continues the work started in [#876](https://github.com/fosrl/pangolin/pull/876), focusing on automating TypeScript linting. Key changes: - The TypeScript linter now runs automatically on every PR only if TypeScript files are modified. - Replaces the previous, stricter ruleset with a much more lenient configuration. - This configuration allows for the addition of rules slowly, instead of "everything all at once" - Removes the "typescript recommended" ruleset. - Currently, only semicolon-related issues are treated as errors. - `@typescript-eslint/no-unused-vars` is now treated as a warning to avoid blocking this PR. Once those warnings are resolved across the codebase, we plan to elevate it to an error level. - Auto-fixed most existing semicolon-related issues for consistency. ## How to test? 1. Create or update a PR that modifies .ts or .tsx files. 2. Confirm that the linter runs automatically via GitHub Actions. 3. Ensure the CI only fails on semicolon issues, not on unused variable warnings. #### P.S. If you have any more requests on DevOps/automation work, please let me know, I'll be happy to help :)

MrUnknownDE closed this issue

2026-04-05 19:16:32 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#1376