fix: Credenza dialog max-height overflow hiding footer buttons #2572 #136

New Issue

MrUnknownDE · 2026-04-05T17:01:22+02:00

MrUnknownDE commented

2026-04-05 17:01:22 +02:00

Originally created by @shreyaspapi on 3/10/2026

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Fixes #2572

The CredenzaContent component on desktop used max-h-screen (100vh) but was positioned with top: clamp(1.5rem, 12vh, 200px). This caused the dialog to extend up to 200px below the viewport, hiding the footer and its "Done" button behind the OS taskbar.

Changed md:max-h-screen to md:max-h-[calc(100vh-clamp(3rem,24vh,400px))] so the max-height subtracts the top offset (doubled to reserve equal space at top and bottom), keeping the dialog fully within the viewport.

How to test?

Open any resource and navigate to Proxy tab
Click the healthcheck icon on a target to open the HealthCheck dialog
Toggle healthcheck Enabled to expand all form fields
Verify the "Done" button is visible at 100% zoom without needing to scroll the page
Zoom in/out — the dialog should stay within the viewport and scroll internally

*Originally created by @shreyaspapi on 3/10/2026* ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Fixes #2572 The `CredenzaContent` component on desktop used `max-h-screen` (100vh) but was positioned with `top: clamp(1.5rem, 12vh, 200px)`. This caused the dialog to extend up to 200px below the viewport, hiding the footer and its "Done" button behind the OS taskbar. Changed `md:max-h-screen` to `md:max-h-[calc(100vh-clamp(3rem,24vh,400px))]` so the max-height subtracts the top offset (doubled to reserve equal space at top and bottom), keeping the dialog fully within the viewport. ## How to test? 1. Open any resource and navigate to **Proxy** tab 2. Click the healthcheck icon on a target to open the HealthCheck dialog 3. Toggle healthcheck **Enabled** to expand all form fields 4. Verify the **"Done" button** is visible at 100% zoom without needing to scroll the page 5. Zoom in/out — the dialog should stay within the viewport and scroll internally

MrUnknownDE closed this issue

2026-04-05 17:01:22 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#136