Fix ESLint issues: prefer-const warnings and missing semicolons #1194

New Issue

MrUnknownDE · 2026-04-05T18:29:27+02:00

MrUnknownDE commented

2026-04-05 18:29:27 +02:00

Originally created by @Copilot on 7/22/2025

This PR resolves all ESLint issues identified in the codebase by fixing prefer-const warnings and missing semicolon errors.

Issues Fixed

Before:

66 prefer-const warnings - variables declared with let that are never reassigned
4 missing semicolon errors
Total: 70 ESLint problems

After:

0 ESLint warnings or errors ✅

Changes Made

Automated Fixes (ESLint --fix)

Used ESLint's built-in --fix capability to automatically resolve 58 out of 70 issues
Changed let to const for variables that are never reassigned across server routers and React components
Added missing semicolons in error-prone locations

Manual Fixes

Fixed remaining 12 prefer-const warnings in migration scripts where ESLint couldn't auto-fix due to declaration/assignment separation

Consolidated variable declarations like:

// Before
let rawConfig: any;
rawConfig = yaml.load(fileContents);

// After  
const rawConfig: any = yaml.load(fileContents);

Files Modified

39 files across server/ and src/ directories
Server routers: API endpoints, authentication, and business logic
Setup scripts: Database migration scripts
React components: UI pages and forms

Impact

No functional changes - all modifications are code style improvements only
Improved code quality - follows TypeScript/ESLint best practices
Better maintainability - clearer intent with const vs let usage

Verification

✅ ESLint passes with zero warnings/errors
✅ TypeScript syntax validation confirms changes are correct
✅ All changes are minimal and surgical (38 insertions, 38 deletions)

Fixes #1112.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

fonts.googleapis.com

Triggering command: node /home/REDACTED/work/pangolin/pangolin/node_modules/.bin/next build (dns block)

scarf.sh

Triggering command: node ./report.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled

Add the appropriate URLs or hosts to my firewall allow list

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

*Originally created by @Copilot on 7/22/2025* This PR resolves all ESLint issues identified in the codebase by fixing `prefer-const` warnings and missing semicolon errors. ## Issues Fixed **Before:** - 66 `prefer-const` warnings - variables declared with `let` that are never reassigned - 4 missing semicolon errors - Total: 70 ESLint problems **After:** - 0 ESLint warnings or errors ✅ ## Changes Made ### Automated Fixes (ESLint --fix) - Used ESLint's built-in `--fix` capability to automatically resolve 58 out of 70 issues - Changed `let` to `const` for variables that are never reassigned across server routers and React components - Added missing semicolons in error-prone locations ### Manual Fixes - Fixed remaining 12 `prefer-const` warnings in migration scripts where ESLint couldn't auto-fix due to declaration/assignment separation - Consolidated variable declarations like: ```typescript // Before let rawConfig: any; rawConfig = yaml.load(fileContents); // After const rawConfig: any = yaml.load(fileContents); ``` ## Files Modified - **39 files** across `server/` and `src/` directories - **Server routers:** API endpoints, authentication, and business logic - **Setup scripts:** Database migration scripts - **React components:** UI pages and forms ## Impact - **No functional changes** - all modifications are code style improvements only - **Improved code quality** - follows TypeScript/ESLint best practices - **Better maintainability** - clearer intent with `const` vs `let` usage ## Verification - ✅ ESLint passes with zero warnings/errors - ✅ TypeScript syntax validation confirms changes are correct - ✅ All changes are minimal and surgical (38 insertions, 38 deletions) Fixes #1112. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `fonts.googleapis.com` > - Triggering command: `node /home/REDACTED/work/pangolin/pangolin/node_modules/.bin/next build` (dns block) > - `scarf.sh` > - Triggering command: `node ./report.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to my [firewall allow list](https://gh.io/copilot/firewall-config) > > </details>  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

MrUnknownDE closed this issue

2026-04-05 18:29:27 +02:00

Sign in to join this conversation.

Branches Tags

main

dev

dependabot/npm_and_yarn/dev-minor-updates-b4e5d6b9c5

revert-2766-feature/systemd-install-instructions

dependabot/npm_and_yarn/prod-patch-updates-05702d39f2

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

alerting-rules

private-site-ha

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/pangolin#1194