Add option of "existingSecret" for oneuptimeSecret and encryptionSecret #711

Closed
opened 2026-04-05 16:22:14 +02:00 by MrUnknownDE · 0 comments
Owner

Originally created by @luisxkimo on 9/6/2024

Is your feature request related to a problem? Please describe.

We can't use "external" secrets to add custom values for oneuptimeSecret and encryptionSecret. This makes insecure this secret when we want to upload the helm values file to a repository.

Describe the solution you'd like
Like in the configuration of externalPostgres, add to the configuration of the Helm chart to enable use custom existing secret.

Describe alternatives you've considered
If I'm right, in _helpers.tpl should be something like this:

- name: ONEUPTIME_SECRET
  {{- if $.Values.oneuptimeSecret }}
  value: {{ $.Values.oneuptimeSecret }}
  {{- else }}
  
  {{- if $.Values.externalOneuptimeSecret.existingSecret.name }}
  valueFrom:
    secretKeyRef:
        name: {{ printf "%s" $.Values.externalOneuptimeSecret.existingSecret.name }}
        key: {{ $.Values.externalOneuptimeSecret.existingSecret.passwordKey }}
  {{- else }}
  valueFrom:
    secretKeyRef:
      name: {{ printf "%s-%s" $.Release.Name "secrets"  }}
      key: oneuptime-secret
  {{- end }}
  {{- end }}

Same for ENCRYPTION_SECRET

*Originally created by @luisxkimo on 9/6/2024* **Is your feature request related to a problem? Please describe.** We can't use "external" secrets to add custom values for _oneuptimeSecret_ and _encryptionSecret_. This makes _insecure_ this secret when we want to upload the helm values file to a repository. **Describe the solution you'd like** Like in the configuration of _externalPostgres_, add to the configuration of the Helm chart to enable use custom existing secret. **Describe alternatives you've considered** If I'm right, in _helpers.tpl should be something like this: ``` - name: ONEUPTIME_SECRET {{- if $.Values.oneuptimeSecret }} value: {{ $.Values.oneuptimeSecret }} {{- else }} {{- if $.Values.externalOneuptimeSecret.existingSecret.name }} valueFrom: secretKeyRef: name: {{ printf "%s" $.Values.externalOneuptimeSecret.existingSecret.name }} key: {{ $.Values.externalOneuptimeSecret.existingSecret.passwordKey }} {{- else }} valueFrom: secretKeyRef: name: {{ printf "%s-%s" $.Release.Name "secrets" }} key: oneuptime-secret {{- end }} {{- end }} ``` Same for ENCRYPTION_SECRET
Sign in to join this conversation.
No Label enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement enhancement
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/oneuptime#711