Fix Incident Number Concatenating instead of incrementing #529

Closed
opened 2026-04-05 16:20:20 +02:00 by MrUnknownDE · 0 comments
Owner

Originally created by @KoalaG on 3/20/2025

In some instances, database ORM is returning a string instead of a number. This commit ensures that a number is returned by this function.

Title of this pull request?

Fix Incident Number Concatenating instead of incrementing

Small Description?

Simple fix to ensure that function is returning a number instead of a string

Pull Request Checklist:

  • Please make sure all jobs pass before requesting a review.
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
  • Have you lint your code locally before submission? - No
  • Did you write tests where appropriate?

No related issue raised, direct fix as similar to issue #1854

Screenshots (if appropriate):

*Originally created by @KoalaG on 3/20/2025* In some instances, database ORM is returning a string instead of a number. This commit ensures that a number is returned by this function. ### Title of this pull request? Fix Incident Number Concatenating instead of incrementing ### Small Description? Simple fix to ensure that function is returning a number instead of a string ### Pull Request Checklist: - [ ] Please make sure all jobs pass before requesting a review. - [X] Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). - [ ] Have you lint your code locally before submission? - No - [X] Did you write tests where appropriate? ### Related Issue? No related issue raised, direct fix as similar to issue #1854 ### Screenshots (if appropriate):
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/oneuptime#529