From 6301e24c02134e6ac0cf370098c2b4331beb27dd Mon Sep 17 00:00:00 2001
From: Simon Larsen <simonlarsen@oneuptime.com>
Date: Wed, 17 Sep 2025 15:37:03 +0100
Subject: [PATCH] refactor: Add Microsoft Teams app client ID and secret to
 configuration files

---
 HelmChart/Public/oneuptime/templates/_helpers.tpl | 8 ++++++++
 HelmChart/Public/oneuptime/values.yaml            | 3 +++
 docker-compose.base.yml                           | 3 ---
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/HelmChart/Public/oneuptime/templates/_helpers.tpl b/HelmChart/Public/oneuptime/templates/_helpers.tpl
index 843adc9fe3..50506910e5 100644
--- a/HelmChart/Public/oneuptime/templates/_helpers.tpl
+++ b/HelmChart/Public/oneuptime/templates/_helpers.tpl
@@ -12,6 +12,10 @@ Usage:
 {{- end -}}
 
 {{- define "oneuptime.env.common" }}
+
+- name: MICROSOFT_TEAMS_APP_CLIENT_ID
+  value: {{ $.Values.microsoftTeamsApp.clientId }}
+
 {{- if $.Values.openTelemetryExporter.endpoint }}
 - name: OPENTELEMETRY_EXPORTER_OTLP_ENDPOINT
   value: {{ $.Values.openTelemetryExporter.endpoint }}
@@ -171,6 +175,10 @@ Usage:
 - name: SLACK_APP_SIGNING_SECRET
   value: {{ $.Values.slackApp.signingSecret }}
 
+- name: MICROSOFT_TEAMS_APP_CLIENT_SECRET
+  value: {{ $.Values.microsoftTeamsApp.clientSecret }}
+
+
 - name: NOTIFICATION_SLACK_WEBHOOK_ON_CREATED_USER
   value: {{ $.Values.notifications.webhooks.slack.onCreateUser }}
 
diff --git a/HelmChart/Public/oneuptime/values.yaml b/HelmChart/Public/oneuptime/values.yaml
index fd171bab70..4bf64217cf 100644
--- a/HelmChart/Public/oneuptime/values.yaml
+++ b/HelmChart/Public/oneuptime/values.yaml
@@ -754,6 +754,9 @@ slackApp:
   clientSecret:
   signingSecret:
 
+microsoftTeamsApp: 
+  clientId:
+  clientSecret:
 
 keda:
   enabled: true
\ No newline at end of file
diff --git a/docker-compose.base.yml b/docker-compose.base.yml
index 27ee2b31cf..e13aed8495 100644
--- a/docker-compose.base.yml
+++ b/docker-compose.base.yml
@@ -136,9 +136,6 @@ x-common-server-variables: &common-server-variables
     MICROSOFT_TEAMS_APP_CLIENT_ID: ${MICROSOFT_TEAMS_APP_CLIENT_ID}
     MICROSOFT_TEAMS_APP_CLIENT_SECRET: ${MICROSOFT_TEAMS_APP_CLIENT_SECRET}
 
-    # App Version
-    APP_VERSION: ${APP_VERSION}
-
 services: