Fixes #20389: Add FilterSet support to BulkRenameView #986

New Issue

MrUnknownDE · 2026-04-05T19:29:50+02:00

MrUnknownDE commented

2026-04-05 19:29:50 +02:00

Originally created by @pheus on 10/24/2025

Fixes: #20389

Summary
Make BulkRenameView honor “Select all N matching query”, aligning behavior with BulkEditView/BulkDeleteView.

What changed

BulkRenameView now accepts a filterset.
When _all/select_all is posted, the target queryset is derived via filterset(request.GET, self.get_queryset(request)); otherwise it uses the posted pk[].
Add a test confirming selection (37 interfaces) is fully renamed.

Impact
No UI or API changes; bulk actions now behave consistently across edit/delete/rename.

*Originally created by @pheus on 10/24/2025*  ### Fixes: #20389 **Summary** Make `BulkRenameView` honor **“Select all N matching query”**, aligning behavior with `BulkEditView`/`BulkDeleteView`. **What changed** - `BulkRenameView` now accepts a `filterset`. - When `_all`/`select_all` is posted, the target queryset is derived via `filterset(request.GET, self.get_queryset(request))`; otherwise it uses the posted `pk[]`. - Add a test confirming selection (37 interfaces) is fully renamed. **Impact** No UI or API changes; bulk actions now behave consistently across edit/delete/rename.

MrUnknownDE closed this issue

2026-04-05 19:29:50 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#986