Fixes #20646: Prevent cables from connecting to marked_connected objects #980

New Issue

MrUnknownDE · 2026-04-05T19:26:44+02:00

MrUnknownDE commented

2026-04-05 19:26:44 +02:00

Originally created by @pheus on 10/24/2025

Fixes: #20646

Restricts creating cable terminations for endpoints flagged as "mark connected" to avoid the invalid state of being both virtually connected and physically cabled. The validation is implemented in dcim.CableTermination.clean(), ensuring consistent behavior across the UI, REST API, and CSV import. Includes a test covering the rejection case.

Summary of Changes

Add a guard in CableTermination.clean() to raise ValidationError when termination.mark_connected == True.
Keep the check generic so it applies to any cabled model exposing mark_connected (e.g., interfaces, power/power-feed ports, front/rear ports, circuit terminations).
Add test exercising:
- rejection when the endpoint is mark_connected

*Originally created by @pheus on 10/24/2025*  ### Fixes: #20646  Restricts creating cable terminations for endpoints flagged as **"mark connected"** to avoid the invalid state of being both virtually connected and physically cabled. The validation is implemented in `dcim.CableTermination.clean()`, ensuring consistent behavior across the UI, REST API, and CSV import. Includes a test covering the rejection case. #### Summary of Changes - Add a guard in `CableTermination.clean()` to raise `ValidationError` when `termination.mark_connected == True`. - Keep the check generic so it applies to any cabled model exposing `mark_connected` (e.g., interfaces, power/power-feed ports, front/rear ports, circuit terminations). - Add test exercising: - rejection when the endpoint is `mark_connected`

MrUnknownDE closed this issue

2026-04-05 19:26:44 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#980

Fixes #20646: Prevent cables from connecting to marked_connected objects #980

Fixes: #20646

Summary of Changes

Fixes #20646: Prevent cables from connecting to `marked_connected` objects #980