Closes #19338 - Add in_list and exact support on all id and enum fields in GraphQL v2 #978

New Issue

MrUnknownDE · 2026-04-05T19:25:34+02:00

MrUnknownDE commented

2026-04-05 19:25:34 +02:00

Originally created by @bctiemann on 10/24/2025

Closes: #19338

Converts all id fields and all enum-based fields to FilterLookups, which support in_list and exact querying.

Changes BaseObjectTypeFilterMixin and ChangeLogFilterMixin (which are used by most if not all field types) to define id using a FilterLookup instead of UNSET.
In all apps' filters.py, all fields defined as a choice of enum values has similarly been redefined using a FilterLookup, with the same new lookup support.

Note: The linter really does not like this kind of typing syntax, but I wasn't able to find a better way to do it:

    authentication_algorithm: (
        FilterLookup[Annotated['AuthenticationAlgorithmEnum', strawberry.lazy('vpn.graphql.enums')]] | None
    ) = (
        strawberry_django.filter_field()
    )

Note: Depends on https://github.com/netbox-community/netbox/pull/20667

*Originally created by @bctiemann on 10/24/2025* ### Closes: #19338 Converts all `id` fields and all enum-based fields to `FilterLookup`s, which support `in_list` and `exact` querying. - Changes `BaseObjectTypeFilterMixin` and `ChangeLogFilterMixin` (which are used by most if not all field types) to define `id` using a `FilterLookup` instead of `UNSET`. - In all apps' `filters.py`, all fields defined as a choice of enum values has similarly been redefined using a `FilterLookup`, with the same new lookup support. Note: The linter really does not like this kind of typing syntax, but I wasn't able to find a better way to do it: ``` authentication_algorithm: ( FilterLookup[Annotated['AuthenticationAlgorithmEnum', strawberry.lazy('vpn.graphql.enums')]] | None ) = ( strawberry_django.filter_field() ) ``` **Note:** Depends on https://github.com/netbox-community/netbox/pull/20667

MrUnknownDE closed this issue

2026-04-05 19:25:34 +02:00

MrUnknownDE added the status: blocked status: blocked status: blocked status: blocked labels 2026-04-05 19:25:34 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label status: blocked status: blocked status: blocked status: blocked

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#978