Fixes #20697: Ensure unique signal handlers for counter models #956

New Issue

MrUnknownDE · 2026-04-05T19:09:49+02:00

MrUnknownDE commented

2026-04-05 19:09:49 +02:00

Originally created by @pheus on 10/28/2025

Fixes: #20697

Summary
Prevent double counting in CounterCacheField by ensuring signal receivers are connected once per sender.

Implementation

Update utilities.counters.connect_counters() to use per‑sender dispatch_uid for post_save, pre_delete, and post_delete.
Guard against reconnecting by tracking models already processed during registration.
Leave a single receiver to update all registered counters for the same sender (e.g., device_count and member_count).

Impact

Fixes +2/−2 updates when multiple counters share the same child model (e.g., Device).
No database changes; backward‑compatible internal wiring change.

*Originally created by @pheus on 10/28/2025*  ### Fixes: #20697 **Summary** Prevent double counting in `CounterCacheField` by ensuring signal receivers are connected **once per sender**. **Implementation** - Update `utilities.counters.connect_counters()` to use per‑sender `dispatch_uid` for `post_save`, `pre_delete`, and `post_delete`. - Guard against reconnecting by tracking models already processed during registration. - Leave a single receiver to update all registered counters for the same sender (e.g., `device_count` and `member_count`). **Impact** - Fixes `+2/−2` updates when multiple counters share the same child model (e.g., `Device`). - No database changes; backward‑compatible internal wiring change.

MrUnknownDE closed this issue

2026-04-05 19:09:49 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#956