Fixes: #20670: Related Object Validation #944

New Issue

MrUnknownDE · 2026-04-05T19:05:38+02:00

MrUnknownDE commented

2026-04-05 19:05:38 +02:00

Originally created by @m-hau on 10/30/2025

Fixes: #20670

Explicitly check that any related object field is a list, and that each related object is a dictionary, and trigger a validation error if this is not the case. This prevents these cases to result in a hard internal error to occur.

While testing I also found three other minor issues in the same code area, which I took the liberty to fix as well:

Related objects are no longer indexed by 0 in the validation errors, but now from 1 like the top-level objects ("records")
Related object validation errors now show the correct top-level object ("record") index
Change the "Object with ID x does not exist" error to use the same format and channel as all other validation errors

Please see the individual commit messages for more detailed information on each individual change.

*Originally created by @m-hau on 10/30/2025*  ### Fixes: #20670 Explicitly check that any related object field is a list, and that each related object is a dictionary, and trigger a validation error if this is not the case. This prevents these cases to result in a hard internal error to occur. While testing I also found three other minor issues in the same code area, which I took the liberty to fix as well: - Related objects are no longer indexed by 0 in the validation errors, but now from 1 like the top-level objects ("records") - Related object validation errors now show the correct top-level object ("record") index - Change the "Object with ID x does not exist" error to use the same format and channel as all other validation errors Please see the individual commit messages for more detailed information on each individual change.

MrUnknownDE closed this issue

2026-04-05 19:05:38 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#944