Closes #20823: Validate Token expiration date on creation #829

New Issue

MrUnknownDE · 2026-04-05T18:00:17+02:00

MrUnknownDE commented

2026-04-05 18:00:17 +02:00

Originally created by @pheus on 11/21/2025

Fixes: #20823

This PR adds model-level validation to prevent creating API tokens with an expiration date in the past, while still allowing updates to existing tokens (including already-expired ones).

Changes:

Updates Token.clean() to raise a ValidationError when creating a new token (pk is None) whose expires timestamp is already in the past.
Leaves updates to existing tokens unchanged so that expired tokens can still be modified as needed.
Adds tests in users/tests/test_models.py covering:
- the Token.is_expired property for None, future, and past expiration times
- creation of tokens with a past expiration date
- updates to existing expired tokens

No database or API schema changes are introduced by this PR.

*Originally created by @pheus on 11/21/2025*  ### Fixes: #20823  This PR adds model-level validation to prevent creating API tokens with an expiration date in the past, while still allowing updates to existing tokens (including already-expired ones). Changes: - Updates `Token.clean()` to raise a `ValidationError` when creating a new token (`pk is None`) whose `expires` timestamp is already in the past. - Leaves updates to existing tokens unchanged so that expired tokens can still be modified as needed. - Adds tests in `users/tests/test_models.py` covering: - the `Token.is_expired` property for `None`, future, and past expiration times - creation of tokens with a past expiration date - updates to existing expired tokens No database or API schema changes are introduced by this PR.

MrUnknownDE closed this issue

2026-04-05 18:00:17 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#829