Fix {module} placeholder resolution in module bay position field #81

New Issue

MrUnknownDE · 2026-04-05T16:21:31+02:00

MrUnknownDE commented

2026-04-05 16:21:31 +02:00

Originally created by @mrmrcoleman on 3/25/2026

Fixes: #20467

Summary

Fixes a bug where the {module} placeholder in a ModuleBayTemplate's position field was not being resolved when a module was installed, leaving the literal string {module} in the position value.

The {module} placeholder already worked correctly in the name and label fields — this brings position into parity.

Changes

File	Change
`dcim/models/device_component_templates.py`	Add `resolve_position()` method; consolidate shared resolution logic into `_resolve_module_placeholder()` to eliminate duplication across `resolve_name`, `resolve_label`, and `resolve_position`
`dcim/tests/test_models.py`	Regression test: module bay template with `position='{module}-1'` resolves to `1-1` when installed under a parent bay with position `1`

Testing

All existing dcim model and form tests pass (60 tests). Added one regression test that verifies:

Create a device type with a module bay (position 1)
Create a module type with a sub-bay template using position='{module}-1'
Install the module — verify the sub-bay's position resolves to 1-1

*Originally created by @mrmrcoleman on 3/25/2026* ### Fixes: #20467 ## Summary Fixes a bug where the `{module}` placeholder in a `ModuleBayTemplate`'s position field was not being resolved when a module was installed, leaving the literal string `{module}` in the position value. The `{module}` placeholder already worked correctly in the `name` and `label` fields — this brings `position` into parity. ## Changes | File | Change | |------|--------| | `dcim/models/device_component_templates.py` | Add `resolve_position()` method; consolidate shared resolution logic into `_resolve_module_placeholder()` to eliminate duplication across `resolve_name`, `resolve_label`, and `resolve_position` | | `dcim/tests/test_models.py` | Regression test: module bay template with `position='{module}-1'` resolves to `1-1` when installed under a parent bay with position `1` | ## Testing All existing dcim model and form tests pass (60 tests). Added one regression test that verifies: 1. Create a device type with a module bay (position `1`) 2. Create a module type with a sub-bay template using `position='{module}-1'` 3. Install the module — verify the sub-bay's position resolves to `1-1`

MrUnknownDE closed this issue

2026-04-05 16:21:31 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#81