Fixes #20560: Fix VLAN disambiguation in prefix bulk import #770

New Issue

MrUnknownDE · 2026-04-05T17:32:55+02:00

MrUnknownDE commented

2026-04-05 17:32:55 +02:00

Originally created by @jnovinger on 12/5/2025

Fixes: #20560

When vlan_site is specified during prefix bulk import, the form should only match VLANs at that specific site. The previous implementation included VLANs with NULL site (global VLANs), which caused "multiple objects were found" errors when both a global VLAN and site-specific VLAN existed with the same vid.

Removed NULL site inclusion from PrefixImportForm.__init__
Added regression tests for disambiguation between site-specific VLANs and between global/site-specific VLANs
Completes the fix started in PR #18844 which added the vlan_site field but inadvertently carried forward the NULL inclusion bug

*Originally created by @jnovinger on 12/5/2025* ### Fixes: #20560 When `vlan_site` is specified during prefix bulk import, the form should only match VLANs at that specific site. The previous implementation included VLANs with `NULL` site (global VLANs), which caused "multiple objects were found" errors when both a global VLAN and site-specific VLAN existed with the same vid. - Removed NULL site inclusion from `PrefixImportForm.__init__` - Added regression tests for disambiguation between site-specific VLANs and between global/site-specific VLANs - Completes the fix started in PR #18844 which added the `vlan_site` field but inadvertently carried forward the NULL inclusion bug

MrUnknownDE closed this issue

2026-04-05 17:32:55 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#770