Fixes #20491: Normalize numeric range array fields for API test comparisons #745

New Issue

MrUnknownDE · 2026-04-05T17:25:00+02:00

MrUnknownDE commented

2026-04-05 17:25:00 +02:00

Originally created by @pheus on 12/10/2025

Fixes: #20491

This PR updates the API testing utilities so that numeric range array fields are represented consistently with the API serializers.

Specifically:

In utilities.testing.base.model_to_dict(), when api=True and the field is an ArrayField of a RangeField (e.g. ArrayField(IntegerRangeField)), the values are converted from psycopg's canonical half‑open ranges [low, high) into inclusive [low, high] pairs before comparison.
This matches the behavior of IntegerRangeSerializer(many=True, required=False), which exposes ranges as inclusive [low, high] pairs at the API boundary (for example, VLANGroup.vid_ranges).
The change is limited to the test harness and does not affect runtime behavior or the public API; it only ensures that APIViewTestCase compares data using the same representation as the serializers.

As a small regression check, the VLAN group API test (VLANGroupTest in ipam.tests.test_api) is updated to include a vid_ranges value in create_data so that this path is exercised automatically going forward.

*Originally created by @pheus on 12/10/2025* ### Fixes: #20491 This PR updates the API testing utilities so that numeric range array fields are represented consistently with the API serializers. Specifically: - In `utilities.testing.base.model_to_dict()`, when `api=True` and the field is an `ArrayField` of a `RangeField` (e.g. `ArrayField(IntegerRangeField)`), the values are converted from psycopg's canonical half‑open ranges `[low, high)` into inclusive `[low, high]` pairs before comparison. - This matches the behavior of `IntegerRangeSerializer(many=True, required=False)`, which exposes ranges as inclusive `[low, high]` pairs at the API boundary (for example, `VLANGroup.vid_ranges`). - The change is limited to the test harness and does not affect runtime behavior or the public API; it only ensures that `APIViewTestCase` compares data using the same representation as the serializers. As a small regression check, the VLAN group API test (`VLANGroupTest` in `ipam.tests.test_api`) is updated to include a `vid_ranges` value in `create_data` so that this path is exercised automatically going forward.

MrUnknownDE closed this issue

2026-04-05 17:25:00 +02:00

Sign in to join this conversation.

Branches Tags

main

21455-sql-indexes-audit

21357-register-model-actions

feature

20924-plugin-ui-components

21766-improve-test-coverage-for-sortable-table-columns

21157-export-template-public-models

21025-pre-render-config-contexts

21364-swagger

feature-ip-prefix-link

20911-dropdown-3

fix_module_substitution

21160-filterset

20911-dropdown-2

20044-elevation-stuck-lightmode

7604-filter-modifiers-v3

20660-script-load

19724-graphql

14884-script

19720-macaddress-interface-generic-relation

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/netbox#745